Skip to content

Ability to make quotes on comments#5647

Merged
tramuntanal merged 9 commits intomasterfrom
feat/render-quotes-in-comments
Feb 9, 2020
Merged

Ability to make quotes on comments#5647
tramuntanal merged 9 commits intomasterfrom
feat/render-quotes-in-comments

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Jan 23, 2020

🎩 What? Why?

On comments:

  • As a registered user I can make quotes with ">"
  • As a visitor I can see the quote formated correctly

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry

📷 Screenshots (optional)

Screenshot 2020-01-23 at 08 44 15

Screenshot 2020-01-23 at 08 44 25

@agustibr agustibr added this to the PAM 2020 release 1 milestone Jan 23, 2020
@agustibr agustibr self-assigned this Jan 23, 2020
@mrcasals
Copy link
Copy Markdown
Contributor

I've made quotes support multilines and paragraphs inside:

image

@mrcasals mrcasals force-pushed the feat/render-quotes-in-comments branch from 3ae41ed to 28d0dcd Compare January 24, 2020 08:17
@mrcasals mrcasals marked this pull request as ready for review January 24, 2020 08:34
@mrcasals
Copy link
Copy Markdown
Contributor

@decidim/core this has been approved by @decidim/product, can you review it please? Thanks!

@mrcasals mrcasals requested a review from tramuntanal January 27, 2020 09:37
@mrcasals mrcasals assigned mrcasals and unassigned agustibr Jan 27, 2020
@mrcasals mrcasals requested a review from leio10 February 4, 2020 14:48
@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Feb 4, 2020

@agustibr I can't ask for your review because you created the PR, but it'd be awesome if you could check it anyway 😄

Copy link
Copy Markdown
Contributor Author

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrcasals ✅ Approved (I can't review & approve as I'm the creator of the PR 😅 )

leio10
leio10 previously approved these changes Feb 6, 2020
@tramuntanal tramuntanal added the project: PAM2020 Barcelona City Council contract label Feb 8, 2020
tramuntanal
tramuntanal previously approved these changes Feb 9, 2020
@tramuntanal tramuntanal dismissed stale reviews from leio10 and themself via 10a9416 February 9, 2020 18:39
@tramuntanal tramuntanal merged commit 6f7f7fa into master Feb 9, 2020
@tramuntanal tramuntanal deleted the feat/render-quotes-in-comments branch February 9, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: PAM2020 Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

To be able to make quotes on comments

4 participants