Skip to content

Proposals: allow admins to set a predefined template#5613

Merged
tramuntanal merged 8 commits intodecidim:masterfrom
codegram:proposals/predefined-template
Jan 24, 2020
Merged

Proposals: allow admins to set a predefined template#5613
tramuntanal merged 8 commits intodecidim:masterfrom
codegram:proposals/predefined-template

Conversation

@mrcasals
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals commented Jan 9, 2020

🎩 What? Why?

This PR allows admins to set a predefined template for proposals. It also improves the appearance of translated, non-editor text areas in component settings forms, as they were appearing in a single row. I set it to 6 rows in height to make them appear the same as editor text areas.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry

📷 Screenshots (optional)

When trying to create a proposal without modifying the template:
image

Updated appearance of translated, non-editor text areas in component settings form:
image

@mrcasals mrcasals marked this pull request as ready for review January 9, 2020 10:05
@mrcasals mrcasals force-pushed the proposals/predefined-template branch from b8dee49 to 758d630 Compare January 9, 2020 11:59
@mrcasals mrcasals mentioned this pull request Jan 13, 2020
Merged
2 tasks
@mrcasals mrcasals force-pushed the proposals/predefined-template branch from bdbac36 to 6fec877 Compare January 13, 2020 09:23
@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Jan 13, 2020

Hi @decidim/core product has approved this, can you please review the PR?

Thanks!

@mrcasals mrcasals requested a review from tramuntanal January 15, 2020 09:04
@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Jan 17, 2020

Hi @tramuntanal can you review this please? Thanks! 😄

@tramuntanal tramuntanal added in-review project: PAM2020 Barcelona City Council contract labels Jan 17, 2020
tramuntanal
tramuntanal suggested changes Jan 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrcasals , good work 👍
I think you forgot to add the hint in the admin field as specified in the related issue.
Also, can you rename the field from "New proposal template text" to "New proposal body template" to make it more intuitive?

tramuntanal
tramuntanal suggested changes Jan 17, 2020
View reviewed changes
@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Jan 20, 2020

@tramuntanal regarding the label change, I copied what the @decidim/product team posted in the screenshot, so that's the text they asked for. Regarding the hint, I don't see any reference in the original issue, so this PR should be good to go! 😄

@tramuntanal
Copy link
Copy Markdown
Contributor

tramuntanal commented Jan 21, 2020

Hi @mrcasals 🙏 do as I ask regarding the hint. I find it is much more easy for admins this way.
@decidim/product don't you think that it will be easier for admins to also have the label "New proposal body template" in conjunction with the label that appears in the front end that is "body":
image

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Jan 22, 2020

"New proposal body template"

Seems clearer for me.

There was an error on the initial mockup (my bad, sorry). It should be like this:

imatge

@mrcasals mrcasals force-pushed the proposals/predefined-template branch from 8b25f61 to e2870ea Compare January 22, 2020 14:26
@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Jan 22, 2020

OK, locales changed! Check them here:

image

@mrcasals mrcasals requested a review from tramuntanal January 22, 2020 14:26
tramuntanal
tramuntanal previously approved these changes Jan 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, 👌 @mrcasals

One change I would have done but I can't because the PR comes from your fork is s/proposal_template_text/proposal_body_template/

@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Jan 23, 2020

@tramuntanal it comes from a fork because at the time I didn't have permissions to push to this repository. Newer PRs are created directly in this repo, but this one is still old and I can't change it, sorry!

I've push a change with the renaming, you're right I forgot about it. thanks for the review, can you check it again please?

tramuntanal
tramuntanal approved these changes Jan 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@tramuntanal tramuntanal merged commit 38f36f7 into decidim:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tramuntanal tramuntanal tramuntanal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrcasals mrcasals

Labels

in-review project: PAM2020 Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Predefined template in proposals

3 participants

@mrcasals @tramuntanal @andreslucena