Prevent ransack to be updated to vs 2.3 due a bug with polymorphic joins#5303
Merged
oriolgual merged 3 commits intodecidim:masterfrom Aug 23, 2019
Merged
Prevent ransack to be updated to vs 2.3 due a bug with polymorphic joins#5303oriolgual merged 3 commits intodecidim:masterfrom
oriolgual merged 3 commits intodecidim:masterfrom
Conversation
oriolgual
approved these changes
Aug 23, 2019
This was referenced Aug 23, 2019
ahukkanen
added a commit
to mainio/decidim-module-combined_budgeting
that referenced
this pull request
Aug 26, 2019
This was referenced Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Proposals search is broken if bundler upgrades the ransack gem to version 2.3 due (probably) to this bug:
activerecord-hackery/ransack#1039
Until resolved we should ensure that ransack stays at 2.1.x versions.
The error thrown is:
Caused in
decidim-core/lib/decidim/amendable.rbwhen scopesonly_amendablesoronly_emendationsare used.📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)