Change: social share button sites#5270
Merged
oriolgual merged 8 commits intodecidim:masterfrom Jul 25, 2019
Merged
Conversation
decidim-core/app/assets/stylesheets/decidim/extras/_social_share.css.scss
Outdated
Show resolved
Hide resolved
decidim-core/app/assets/stylesheets/decidim/extras/_social_share.css.scss
Outdated
Show resolved
Hide resolved
decidim-core/app/assets/stylesheets/decidim/extras/_social_share.css.scss
Outdated
Show resolved
Hide resolved
decidim-core/app/assets/stylesheets/decidim/extras/_social_share.css.scss
Outdated
Show resolved
Hide resolved
oriolgual
approved these changes
Jul 25, 2019
1 task
Quentinchampenois
added a commit
to OpenSourcePolitics/decidim
that referenced
this pull request
Dec 30, 2019
* Add share to whatsapp and telegram buttons * Move social share button dependecies to core and remove them from modules * Update lock files and remove unused translations * Add specs * Refactor spec * Fix codeclimate offenses * Delete empty files * Add CHANGELOG entry # Conflicts: # Gemfile.lock # decidim-core/app/assets/config/decidim_core_manifest.js # decidim-core/decidim-core.gemspec # decidim-debates/app/views/decidim/debates/debates/_share.html.erb # decidim-debates/config/locales/en.yml # decidim-generators/Gemfile.lock # decidim-initiatives/decidim-initiatives.gemspec # decidim-proposals/decidim-proposals.gemspec # decidim-sortitions/decidim-sortitions.gemspec # decidim_app-design/Gemfile.lock
Quentinchampenois
added a commit
to OpenSourcePolitics/decidim
that referenced
this pull request
Jan 6, 2020
* Add share to whatsapp and telegram buttons * Move social share button dependecies to core and remove them from modules * Update lock files and remove unused translations * Add specs * Refactor spec * Fix codeclimate offenses * Delete empty files * Add CHANGELOG entry # Conflicts: # Gemfile.lock # decidim-core/app/assets/config/decidim_core_manifest.js # decidim-core/decidim-core.gemspec # decidim-debates/app/views/decidim/debates/debates/_share.html.erb # decidim-debates/config/locales/en.yml # decidim-generators/Gemfile.lock # decidim-initiatives/decidim-initiatives.gemspec # decidim-proposals/decidim-proposals.gemspec # decidim-sortitions/decidim-sortitions.gemspec # decidim_app-design/Gemfile.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)