Skip to content

Feat: amendments_visibility component step setting#5223

Merged
oriolgual merged 9 commits intodecidim:masterfrom
CodiTramuntana:feat/amendments_visibility_step_config
Jun 21, 2019
Merged

Feat: amendments_visibility component step setting#5223
oriolgual merged 9 commits intodecidim:masterfrom
CodiTramuntana:feat/amendments_visibility_step_config

Conversation

@aitorlb
Copy link
Copy Markdown
Contributor

@aitorlb aitorlb commented Jun 19, 2019

🎩 What? Why?

The administrator can configure whether amendments are visible to everyone or participants only view the amendments that they have created -> Only when amendment is enabled

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add tests

📷 Screenshots (optional)

amendments_visibility_updated

@aitorlb aitorlb requested a review from a team as a code owner June 19, 2019 10:47
Added two entries as we forgot to add one in the last related PR.
**Added**:

- **decidim-core**, **decidim-admin**, **decidim-proposals**: Add: `amendments_visibility` component step setting [#5223](https://github.com/decidim/decidim/pull/5223)
- **decidim-core**, **decidim-admin**, **decidim-proposals**: Add: admin configuration of amendments by step [#5178](https://github.com/decidim/decidim/pull/5178)
Copy link
Copy Markdown
Contributor Author

@aitorlb aitorlb Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to add a CHANGELOG entry in #5178

Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work @aitorlb !

@aitorlb
Copy link
Copy Markdown
Contributor Author

aitorlb commented Jun 20, 2019

We are trying to come up with the best english translations with @agustibr.

@decidim/lot-core @decidim/product , can you chime in?

Current:

Amendment visibility:
[x] All amendments are visible [ ] Participants can only see their own amendments

Other:

Amendment visibility for Participants:
[x] All emendations are visible to all participants [ ] Participants can only view their amendments

oriolgual
oriolgual previously approved these changes Jun 21, 2019
@carolromero
Copy link
Copy Markdown
Member

Hi @aitorlb I'd go with:

Amendment visibility:
[x] Amendments are visible to all [ ] Amendments are visible only to their authors

⚠️ Also, for consistency reasons, could you please replace "emendation" by "amendment" in the yml files? Thanks!

@aitorlb
Copy link
Copy Markdown
Contributor Author

aitorlb commented Jun 21, 2019

Thanks @carolromero , then the help text would say the following?

If the option "Amendments are visible only to their authors" is selected, participant must be logged in to see the amendments made.

As for:

for consistency reasons, could you please replace "emendation" by "amendment" in the yml files?

Can we do that in a different PR related to its own issue? I just don't know the implications of doing that right now, and @oriolgual has already accepted this PR.

@carolromero
Copy link
Copy Markdown
Member

Hi @aitorlb,
yes and yes to both questions 😊
and good work in this improvement on amendments!

@oriolgual oriolgual merged commit ac74d2d into decidim:master Jun 21, 2019
@aitorlb aitorlb mentioned this pull request Jul 1, 2019
2 tasks
@tramuntanal tramuntanal deleted the feat/amendments_visibility_step_config branch February 19, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants