Admin configuration of amendments by step#5178
Merged
oriolgual merged 11 commits intodecidim:masterfrom Jun 17, 2019
Merged
Conversation
944f4f9 to
086275a
Compare
…n w promoted proposal
086275a to
25c88e2
Compare
Contributor
Author
|
@aitorlb great work! |
I refactored a spec in the last commit but realized after fixing a rubocop warning that the error was not being raised anymore. The error is a regression that was fixed in decidim#5179, which updated the component setting :participatory_texts_enabled from true to false when the checkbox was being disabled from the frontend. I disabled the rubocop warning and made sure the error is catched now, testing it in the branch that introduced the regression.
oriolgual
reviewed
Jun 14, 2019
oriolgual
previously approved these changes
Jun 14, 2019
Contributor
|
@oriolgual the diff of the
|
oriolgual
approved these changes
Jun 17, 2019
Contributor
Author
|
Y'all are great! 😄 ⚙️ |
2 tasks
This was referenced Jul 1, 2019
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Adds ability to admin to configure amendments by step:
Cell to show links to/from rejected emendation with proposal.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)