Fix proposal participants metrics#5048
Conversation
tramuntanal
left a comment
There was a problem hiding this comment.
It seems good to me, but maybe @MarcReniu would better confirm?
mrcasals
left a comment
There was a problem hiding this comment.
Looks good! We can wait for @MarcReniu's approval if you want, though.
MarcReniu
left a comment
There was a problem hiding this comment.
It's good for me! I should add a little comment in docs to take into account future modifications about who can create Proposals
|
@aitorlb can you check @MarcReniu's comment? |
|
Sorry, I didn't see it. Where should this comment go? And what should it say? Any help? |
|
Since this is fixing an important bug, I'll merge this and please add the docs that @MarcReniu suggested in another PR @aitorlb |
|
@aitorlb we would also need a migration or instructions in the changelog to recalculate the metrics that are wrong. |
|
@oriolgual the migration is for the future PR, right? |
Yup |
* Fix participants metrics * Add CHANGELOG entry
|
@oriolgual , @mrcasals , I'm seeing that metrics that are older than two month old don't get rendered in the visualizations. So, should the task to recalculate past metrics fix all existing metrics or only those that are two month old or less? |
|
I guess it's enough with the past two months |
🎩 What? Why?
Changed query to take into account:
Decidim::UserBaseEntity(proposal from users and user groups)Decidim::Organization(official proposals)Decidim::Meetings::Meeting(proposals that come from a meeting)Changed
📌 Related Issues
📋 Subtasks
CHANGELOGentry