Skip to content

Add area to participatory processes#5011

Merged
mrcasals merged 3 commits intodecidim:masterfrom
gencat:add_area_to_participatory_processes
Mar 27, 2019
Merged

Add area to participatory processes#5011
mrcasals merged 3 commits intodecidim:masterfrom
gencat:add_area_to_participatory_processes

Conversation

@isaacmg410
Copy link
Copy Markdown
Contributor

@isaacmg410 isaacmg410 commented Mar 26, 2019

🎩 What? Why?

This Pr adds Area to ParticipatoryProcces

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add Area when copying Assembly
  • Add Area when copying Process
  • Add Area when creating Process
  • Add Area when updating Process
  • Add area_id on participatory process form
  • Add Area on ParticipatoryProcess Show
  • Add relationship between area and process
  • Add area on participatory process presenter
  • Add locales
  • Create migration
  • Improve Specs

📷 Screenshots (optional)

Description

@isaacmg410
Copy link
Copy Markdown
Contributor Author

@decidim/lot-core can you start review it please?
I know that there are some failing specs, also master is broken, I will fix/rebase this branch, when all checks in master will be green

@isaacmg410 isaacmg410 requested a review from tramuntanal March 26, 2019 16:12
@mrcasals
Copy link
Copy Markdown
Contributor

@isaacmg410 master is fixed since #4986

Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should this be shown in the process card too?

@isaacmg410
Copy link
Copy Markdown
Contributor Author

@mrcasals How odd, yesterday was red master 😕

about this:

Should this be shown in the process card too?

I'm not sure... Are we showing the Area in assembly card?

@isaacmg410
Copy link
Copy Markdown
Contributor Author

@mrcasals I've been checked and, we are not showing area in the assembly card, so I wouldn't show it.
Check the screenshot of Assembly cards

screenshot-localhost-3000-2019 03 27-08-54-33

Ready to merge!

@mrcasals
Copy link
Copy Markdown
Contributor

@isaacmg410 I was checking the process, but we only show the hashtag, so merging this!

@mrcasals mrcasals merged commit 919b84f into decidim:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants