Conversation
Contributor
Author
|
Should probably be backported to 0.16. |
oriolgual
previously approved these changes
Mar 20, 2019
Contributor
Author
|
Seems like tests fail due to these issues: heartcombo/devise#5033 (underlying issue is the same) There's a suggested monkey-patch in heartcombo/devise#5033 (comment), but I'm not sure about implementing it. I've subscribed to those issues to check if there are news. |
mrcasals
commented
Mar 25, 2019
Contributor
Author
mrcasals
left a comment
There was a problem hiding this comment.
@oriolgual thanks for taking care of this, code looks good!
oriolgual
approved these changes
Mar 25, 2019
mrcasals
pushed a commit
that referenced
this pull request
Mar 25, 2019
#### 🎩 What? Why? Backport #4986 to `0.16-stable`
mrcasals
pushed a commit
that referenced
this pull request
Mar 25, 2019
#### 🎩 What? Why? Backport #4986 to `0.17-stable`
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We got an automated report that one of our dependencies had a security alert. This PR updates it to a version that solves this problem.
📌 Related Issues
None
📋 Subtasks
None