Merged
Conversation
mrcasals
approved these changes
Jan 4, 2019
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The Moderations dashboard, where the admin manages items that have been reported (i.e. spam), has a rather cryptic behaviour:
report_countto zero, the moderation cannot be hidden again, because reports are what store thehidden_atvalue, nor it can be eliminated, because there's no option for it.report_countto zero (as unreport did) because it really makes no sense to lose that information; it maybe made sense before that the unreport action was being used in practice to allow admins to unhide moderations in the Hidden tab. Finally, as now admin can hide/unhide moderations at will andreport_countdoesn't reset, it made more sense that the unreport action would allow the admin to get rid of a moderation altogether.📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
Moderations Not Hidden Tab
Moderations Hidden Tab (before)
Moderations Hidden Tab (after)