Fix unhideable reported collaborative drafts and mail jobs#4706
Merged
Fix unhideable reported collaborative drafts and mail jobs#4706
Conversation
oriolgual
suggested changes
Dec 20, 2018
Contributor
oriolgual
left a comment
There was a problem hiding this comment.
The changes should be at CollaborativeDraft class, not at Reportable
oriolgual
previously approved these changes
Dec 20, 2018
Contributor
Author
|
Thanks @oriolgual |
Contributor
Author
|
This test doesn't fail in local: |
oriolgual
previously requested changes
Dec 24, 2018
Contributor
oriolgual
left a comment
There was a problem hiding this comment.
Please, update the CHANGELOG and once it's merged could you backport it to 0.16?
Also, in the future it would be better to submit different PRs to solve each issue.
decidim-proposals/app/controllers/decidim/proposals/collaborative_drafts_controller.rb
Outdated
Show resolved
Hide resolved
decidim-proposals/app/controllers/decidim/proposals/proposals_controller.rb
Outdated
Show resolved
Hide resolved
2 tasks
Contributor
Author
|
@oriolgual , you're right. I've made a separate PR for the unrelated refactoring of the admin moderation manager. |
mrcasals
previously approved these changes
Jan 4, 2019
mrcasals
previously approved these changes
Jan 4, 2019
Contributor
|
Please bring this branch up to date so tests can correctly run! 😄 |
Contributor
Author
|
Thanks @mrcasals |
mrcasals
approved these changes
Jan 8, 2019
23 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Also, this PR fixes the following items that were found while investigating the original issue:
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
Collaborative draft report mail job