Conversation
f4c3853 to
6061a63
Compare
27 tasks
9ebdd02 to
d0b733a
Compare
Contributor
Author
|
@decidim/product can you check this into my staging. |
Contributor
Author
|
Also, @decidim/lot-core, I'm not able to insert a background image into pdf. Do you have any idea on how to solve it? cc:// @decidim/lot-px is it possible to change the border style? Also, could you take into account the styles in pdf, maybe needs some refactor? |
845eda7 to
b760e46
Compare
b760e46 to
c9b3739
Compare
Contributor
Author
|
@decidim/lot-core @decidim/lot-px can anyone review this PR and take a look to my comments, please? cc:// @decidim/product |
oriolgual
suggested changes
Nov 13, 2018
decidim-conferences/app/controllers/decidim/conferences/admin/diplomas_controller.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/app/forms/decidim/conferences/admin/diploma_form.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/app/mailers/decidim/conferences/admin/send_conference_diploma_mailer.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/spec/commands/send_conferences_diplomas_spec.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/spec/commands/send_conferences_diplomas_spec.rb
Outdated
Show resolved
Hide resolved
...im-conferences/spec/mailers/decidim/conferences/admin/send_conference_diploma_mailer_spec.rb
Outdated
Show resolved
Hide resolved
Contributor
I don't know, sorry. |
c9b3739 to
d21656d
Compare
d21656d to
e5df63e
Compare
Contributor
Author
|
@decidim/lot-core I've fixed the conflicts. Is there something pending for not merging this PR? |
oriolgual
approved these changes
Nov 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Generate diplomas in an automated way for those users that has their registration confirmed.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)