@decidim/lot-core ready to review!

@rbngzlv what about?

Is it me or there's a missing system spec to test when an admin creates the survey?

Is it me or there's a missing system spec to test when an admin creates the survey?

I'm not sure what to answer to your question, this PR is not related with decidim-surveys, except I needed to rename a factory because a factory with the same name exists inside decidim-conferences. If you mean when an admin adds a surveys component from de admin panel, I don't touched this flow (only the create_survey command in another PR to attach the questionnaire), so I understand that there are the same specs that existed when the surveys component was divided in two, but this PR's isn't touching this part of the surveys component.

@rbngzlv I don't mean the survey component, I mean when an admin adds the registration form to a meeting.

@oriolgual the admin doesn't add any registration form to a meeting. As commented before, the decidim-forms component doesn't have any code to allow admins to create forms in any way; we are attaching a blank questionnaire (persisted in the database) to the meeting when this is created, and the specs for the create_meeting command are updated to check that it attaches a new instance of questionnaire to the newly created meeting. This PR's doesn't add any UI changes that permits and admin to add a registration form to a meeting.

But reading my comment I have thought ... what happens with the already existing meetings? They don't have a questionnaire attached, and will fail ... 😞 Let me work on this.

@oriolgual the admin doesn't add any registration form to a meeting. As commented before, the decidim-forms component doesn't have any code to allow admins to create forms in any way; we are attaching a blank questionnaire (persisted in the database) to the meeting when this is created, and the specs for the create_meeting command are updated to check that it attaches a new instance of questionnaire to the newly created meeting. This PR's doesn't add any UI changes that permits and admin to add a registration form to a meeting.

Ohhh OK, now I understand it.

But reading my comment I have thought ... what happens with the already existing meetings? They don't have a questionnaire attached, and will fail ... 😞 Let me work on this.

I guess we'll need a migration.

@oriolgual migration added.

🎊

@rbngzlv I just realised that a migration to add questionnaires to existing surveys is needed, right? We updated to 0.16 and had some issues with that.

Hi @oriolgual, the refactor for the surveys modules was introduced in this other PR #3877, it contains a rake task that moves data from the decidim-surveys tables to the decidim-forms tables, that was refined by you after test it in a large application with many surveys.

Also, we have added instructions to the upgrade notes: https://github.com/decidim/decidim/blob/0.16-stable/CHANGELOG.md#0160

Oh yes, sorry @rbngzlv, I didn't remember about that!