Skip to content

CoauthorshipsCell render Oficial and Coauthors#4377

Merged
mrcasals merged 1 commit intomasterfrom
fix/coauthorship_cell_w_organization
Oct 25, 2018
Merged

CoauthorshipsCell render Oficial and Coauthors#4377
mrcasals merged 1 commit intomasterfrom
fix/coauthorship_cell_w_organization

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Oct 25, 2018

🎩 What? Why?

Make authors polymorphic #4282 added support for coathorships for official proposals, but coauthorships are not rendered on the UI, only oficial, this PR fixes coauthorships_cell to render all coauthorships on official.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

on a given proposal where

>>  @proposal.coauthorship_ids
=> [21, 22, 23, 24, 25]

>>  @proposal.coauthorships.first
=> #<Decidim::Coauthorship id: 21, decidim_author_id: 1, decidim_user_group_id: nil, coauthorable_type: "Decidim::Proposals::Proposal", coauthorable_id: 5, created_at: "2018-10-23 14:22:14", updated_at: "2018-10-23 14:22:14", decidim_author_type: "Decidim::Organization">

Before:

  • screenshot from 2018-10-25 15-33-34

  • screenshot from 2018-10-25 15-34-53

After:

  • screenshot from 2018-10-25 15-34-06

  • screenshot from 2018-10-25 15-34-21

@ghost ghost assigned agustibr Oct 25, 2018
@ghost ghost added the status: WIP label Oct 25, 2018
@agustibr
Copy link
Copy Markdown
Contributor Author

agustibr commented Oct 25, 2018

@mrcasals seems that test were cancelled 😢

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Oct 25, 2018

@agustibr yeah, that's weird 😕

@agustibr
Copy link
Copy Markdown
Contributor Author

agustibr commented Oct 25, 2018

@mrcasals all checks passed! 😃

@agustibr agustibr requested a review from mrcasals October 25, 2018 14:20
@mrcasals mrcasals merged commit 5c77abe into master Oct 25, 2018
@mrcasals mrcasals deleted the fix/coauthorship_cell_w_organization branch October 25, 2018 14:20
@Xfolchf Xfolchf mentioned this pull request Oct 26, 2018
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mrcasals mrcasals mrcasals approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agustibr agustibr

Labels

in-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agustibr @mrcasals