Allow admins to validate meeting registration codes#3833
Merged
Conversation
oriolgual
suggested changes
Jul 12, 2018
| return broadcast(:invalid) if form.invalid? | ||
|
|
||
| if registration.blank? | ||
| form.errors.add :code, I18n.t("registrations.validate_registration_code.invalid", scope: "decidim.meetings.admin") |
Contributor
There was a problem hiding this comment.
Could you please move this validation to the form?
Contributor
There was a problem hiding this comment.
The command can just call form.registration if you need it here.
| class RegistrationCodeValidatedEvent < Decidim::Events::SimpleEvent | ||
| i18n_attributes :registration_code | ||
|
|
||
| # delegate :code, to: :registration, prefix: true |
Contributor
Author
|
@oriolgual done! Can you take a look? |
6 tasks
oriolgual
approved these changes
Jul 23, 2018
|
@oriolgual this feature is great for quick 0.14 let us know if there is progress on reviewing the code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Allow admins to validate the meeting registration code and notify the user.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)