Skip to content

Let users invite friends#3593

Merged
mrcasals merged 9 commits intomasterfrom
invite-users
Jun 7, 2018
Merged

Let users invite friends#3593
mrcasals merged 9 commits intomasterfrom
invite-users

Conversation

@mrcasals
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals commented Jun 6, 2018

🎩 What? Why?

This PR lets users invite their friends.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add tests

📷 Screenshots (optional)

The email sent to the friend, with a custom message.

Same email, without the custom message:

@mrcasals mrcasals self-assigned this Jun 6, 2018
@ghost ghost added the status: WIP label Jun 6, 2018
admin: false,
role: nil,
invited_by: form.current_user,
invitation_instructions: "invite_admin"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use another template

end

on(:invalid) do
flash[:alert] = if @form.emails.empty?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be flash.now since we're rendering, not redirecting

@mrcasals mrcasals changed the title [WIP] Let users invite friends Let users invite friends Jun 6, 2018
@ghost ghost added the status: WIP label Jun 6, 2018
@mrcasals mrcasals merged commit 92021dc into master Jun 7, 2018
@mrcasals mrcasals deleted the invite-users branch June 7, 2018 08:47
@josepjaume josepjaume added this to the Release v.0.13.0 milestone Jun 11, 2018
oriolgual added a commit that referenced this pull request Nov 6, 2018
@oriolgual oriolgual mentioned this pull request Nov 6, 2018
1 task
oriolgual added a commit that referenced this pull request Nov 6, 2018
oriolgual added a commit that referenced this pull request Nov 6, 2018
* Revert "Let users invite friends (#3593)"

This reverts commit 92021dc.

* Add CHANGELOG
oriolgual added a commit that referenced this pull request Nov 7, 2018
* Revert "Let users invite friends (#3593)"

This reverts commit 92021dc.

* Update CHANGELOG
@oriolgual oriolgual modified the milestones: Release v.0.13.0, CDP4 Dec 10, 2018
@mrcasals mrcasals modified the milestones: CDP4, CDP3 Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants