Merged
Conversation
Contributor
Author
|
This will need to be ported to |
oriolgual
approved these changes
May 24, 2018
oriolgual
approved these changes
May 24, 2018
oriolgual
approved these changes
May 25, 2018
mrcasals
added a commit
that referenced
this pull request
May 25, 2018
* Fix surveys n+1 * Fix specs * Fix tests * Fix tests * Lint files
rbngzlv
added a commit
that referenced
this pull request
May 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We found a N+1 in surveys, where it was loading all the survey answers when rendering the survey form. This is due to how
rectifyforms work: if you have an attribute to the form, and itsmodelresponds to that attribute, the form will automatically call . this method.This meant that if a form had an attribute called
:answers, it automatically callsmodel.answers. In our case, it was causing the app to load all the answers for the given survey, which caused memory problems.📌 Related Issues
None
📋 Subtasks
CHANGELOGentry