Conversation
Contributor
Author
|
@agustibr this is ready and tests should be green, if you want to review it 😄 |
oriolgual
approved these changes
May 9, 2018
Contributor
|
👍 😎 @mrcasals. |
This was referenced May 9, 2018
Merged
Merged
This was referenced May 17, 2018
Merged
Merged
Merged
Merged
isaacmg410
pushed a commit
to CodiTramuntana/decidim
that referenced
this pull request
May 25, 2018
* Fix layout * Improve proposals card * Improve proposal card [ci skip] * Handle different styles of badges * Add tooltips to proposal card status section * Work on follow proposals from card * Start working on meetings cards * Add FollowButtonCell * Fix meetings cells * Remove extra data from proposals card * Improve meeting join button cell * Fix locales * Fix JoinbuttonCell * Allow different "Join" buttons per page * Fix FollowButton cell * Rubocop autofixes * Fix meetings specs * Add changelog entry * Fix proposal cells specs * Fix meetings cells specs * Fix follow button * Fix i18n * Erblint fixes * Remove debug * Fix tests
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR implements the designs by @javierarce and markup by @Crashillo to the platform.
📌 Related Issues
None
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
Meetings:
Proposals when voting is disabled:
Proposals when votes are enabled:
