Conversation
ff8914d to
37885b7
Compare
|
@decidim/lot-core, @deivid-rodriguez I have duplicated three javascripts files from the
I think this javascripts are valid for any nested resource, I'm right? If yes, what do you think about moving this files to the |
|
@rbngzlv They were definitely developed with reusability in mind! :) I agree with moving them to |
7f43eeb to
037065f
Compare
|
@Crashillo can you check my css additions, please? |
46f16c5 to
bbfb839
Compare
bbfb839 to
54a239b
Compare
|
@decidim/lot-core ready to review! |
|
Sorry my late response! Well actually just 15h later! 😝 It is a couple of things we may enhance, I'll write them down as review comments. |
|
Don't worry, I'll made a new PR with your comments. 😄 |
| display: none; | ||
| fill: $anchor-color; | ||
|
|
||
| &.alert{ |
There was a problem hiding this comment.
There's a mixin called modifiers, that you might use to wrap all possibilities (even they're not in use).
Instead of this block, switch it by @include modifiers(fill);. Now, no matter which status you assign to the parent element, the property fill will change accordingly
There was a problem hiding this comment.
Extra tip: I miss $anchor-color is a custom color status, so in that case.... @include modifiers(fill, (alert: $anchor-color)). Now I see again, it's not a big deal, but it's a way to handle statuses in the same way. You'll find other examples in the same file
| } | ||
| } | ||
|
|
||
| .card--list__text--top{ |
There was a problem hiding this comment.
If this property-modified always comes along with .card--list__text, move it inside that block, and and a &. Like:
.card--list__text {
...
// other properties
&.card--list__item--top{
// your properties
}
}
🎩 What? Why?
The admin can define what services will be available in the meeting (simultaneous translation, space enabled for people with functional diversity, children's area, ...)
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)