Conversation
65 tasks
josepjaume
suggested changes
Mar 2, 2018
|
|
||
| flash[:notice] = I18n.t("features.publish.success", scope: "decidim.admin") | ||
| redirect_to action: :index | ||
| PublishFeature.call(@feature, current_user) do |
Contributor
There was a problem hiding this comment.
Looks like these lines are not hit, don't we have tests for this?
|
|
||
| flash[:notice] = I18n.t("features.unpublish.success", scope: "decidim.admin") | ||
| redirect_to action: :index | ||
| UnpublishFeature.call(@feature, current_user) do |
Contributor
There was a problem hiding this comment.
Same on these lines - not covered
Contributor
Author
|
@josepjaume these lines are covered by https://github.com/decidim/decidim/blob/master/decidim-assemblies/spec/shared/manage_assembly_features.rb and https://github.com/decidim/decidim/blob/master/decidim-participatory_processes/spec/system/admin/admin_manages_participatory_process_features_spec.rb Both files check how to publish and unpublish features. |
josepjaume
approved these changes
Mar 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #2884 +/- ##
==========================================
- Coverage 98.72% 98.72% -0.01%
==========================================
Files 1647 1651 +4
Lines 39126 39199 +73
==========================================
+ Hits 38629 38701 +72
- Misses 497 498 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR logs feature (un)publication
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)