Skip to content

Add results to process and process group home#2824

Merged
oriolgual merged 2 commits intomasterfrom
feature/results-process-home
Feb 27, 2018
Merged

Add results to process and process group home#2824
oriolgual merged 2 commits intomasterfrom
feature/results-process-home

Conversation

@rbngzlv
Copy link
Copy Markdown
Contributor

@rbngzlv rbngzlv commented Feb 26, 2018

🎩 What? Why?

Show random results in process/process group home

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry

📷 Screenshots

  • Process home

screencapture-decidim-localhost-processes-beatae-inventore-1519635722403

  • Process group home

screencapture-decidim-localhost-processes_groups-1-1519635706077

@ghost ghost assigned rbngzlv Feb 26, 2018
@ghost ghost added the in-progress label Feb 26, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2018

Codecov Report

Merging #2824 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2824      +/-   ##
==========================================
- Coverage   98.87%   98.86%   -0.01%     
==========================================
  Files        1604     1584      -20     
  Lines       37881    37490     -391     
==========================================
- Hits        37453    37063     -390     
+ Misses        428      427       -1

@rbngzlv
Copy link
Copy Markdown
Contributor Author

rbngzlv commented Feb 26, 2018

@decidim/lot-core Ready to review!

@@ -0,0 +1,12 @@
<% if results.any? %>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this partial be moved inside decidim-accountability?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that I don't understand your comment, can you reword? The partial is already inside the decidim-accountability module.

This is done in the same way that the meetings PR: #2713

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the file is in the correct location 👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I didn't expand the path to the file 😅

@oriolgual oriolgual merged commit 1241ae3 into master Feb 27, 2018
@ghost ghost removed the in-review label Feb 27, 2018
@oriolgual oriolgual deleted the feature/results-process-home branch February 27, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants