Add meetings to process and process group home by rbngzlv · Pull Request #2713 · decidim/decidim

rbngzlv · 2018-02-12T23:03:44Z

🎩 What? Why?

Show past/upcoming meetings in process/process group home

📌 Related Issues

Related to Special content can be added to the process or superprocess home #2273

📋 Subtasks

Add CHANGELOG entry

📷 Screenshots

Process home

Process group home

codecov · 2018-02-13T06:43:27Z

Codecov Report

Merging #2713 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2713      +/-   ##
==========================================
+ Coverage   98.86%   98.86%   +<.01%     
==========================================
  Files        1548     1552       +4     
  Lines       36675    36776     +101     
==========================================
+ Hits        36258    36359     +101     
  Misses        417      417

mrcasals · 2018-02-13T08:23:41Z

...meetings/app/views/decidim/participatory_processes/participatory_processes/_meeting.html.erb

+          <%= translated_attribute meeting.title %>
+        </h6>
+        <span class="text-medium">
+          <%= l meeting.start_time, format: "%d" %> <%= l meeting.start_time, format: "%B %Y" %> -


Format should be delegated to i18n files, you cna add your own format there and link the name here:

http://guides.rubyonrails.org/i18n.html#adding-date-time-formats

mrcasals · 2018-02-13T08:23:54Z

...meetings/app/views/decidim/participatory_processes/participatory_processes/_meeting.html.erb

+        </h6>
+        <span class="text-medium">
+          <%= l meeting.start_time, format: "%d" %> <%= l meeting.start_time, format: "%B %Y" %> -
+          <%= meeting.start_time.strftime("%H:%M") %> - <%= meeting.end_time.strftime("%H:%M") %>


Same here about the formats:

http://guides.rubyonrails.org/i18n.html#adding-date-time-formats

josepjaume

Really good job! Check my comments - I think it should be possible to generalize this outside of the participatory processes.

josepjaume · 2018-02-14T11:24:42Z

decidim-meetings/lib/decidim/meetings/engine.rb

+
+      initializer "decidim_meetings.view_hooks" do
+        if defined? Decidim::ParticipatoryProcesses
+          Decidim::ParticipatoryProcesses.view_hooks.register(:process_highlighted_elements, priority: Decidim::ViewHooks::HIGH_PRIORITY) do |view_context|


Since this is something that probably most participatory spaces will want, what do you think about generalizing this hook so it can be used by any participatory process? Something like participatory_space_highlighted_elements. Then each participatory space can choose whether to render it on its templates or not.

I guess you can add this view hook to decidim-core instead of just decidim-participatory_processes so everyone can benefit from it. Then, from the preocess view, render the view hook from core 😄

rbngzlv · 2018-02-16T16:51:43Z

@mrcasals @josepjaume can you check if everything is correct now?

rbngzlv · 2018-02-16T16:57:01Z

I have a question about the change log entry! I need to add two entries, right? One to the participatory processes and another to the meetings, correct?

xabier · 2018-02-18T17:56:12Z

Hi, I hope not to be late on this. It is not a big issue but "upcoming events" is a much higher value information than "documents" or "related photos" for the process home page. Is it possible to change the order? If this is going to make the PR take considerably longer don't worry.

josepjaume · 2018-02-20T13:59:12Z

@rbngzlv yes I'd do that - even if we've abstracted them away, from the user's perspective it's a change in both sides.

@xabier that's definitely viable by correctly specifying priority (

decidim/decidim-participatory_processes/lib/decidim/participatory_processes/engine.rb

Line 66 in 14adefb

    
           Decidim.view_hooks.register(:highlighted_elements, priority: Decidim::ViewHooks::HIGH_PRIORITY) do |view_context|

). @rbngzlv can you do this and call it a day? 💃

rbngzlv · 2018-02-21T20:37:22Z

I already have the :participatory_space_highlighted_elements view hook registered with Decidim::ViewHooks::HIGH_PRIORITY. The "problem" here is that the "documents" and "related photos" are not rendered using view_hooks.

<%= attachments_for current_participatory_space %>
<%= render_hook(:participatory_space_highlighted_elements) %>

If you want, I can change the order and render the view hooks before documents.

josepjaume · 2018-02-21T20:47:28Z

@rbngzlv okay for me. Maybe we can move all that to view hooks at some point?

rbngzlv · 2018-02-22T08:14:39Z

@josepjaume Done!

@decidim/lot-core It is ready for a second review!

rbngzlv · 2018-02-22T16:57:20Z

@decidim/lot-core sorry for ping, but I need to also add proposals and results as highlighted content to the process and process group home. I'm waiting to have this PR merged to do it, so we have three small PR, but perhaps you prefer to (or we can) have all changes in this PR?

josepjaume

Oh, sorry! I was definitely blocking this. Looks nice the way it is - let's merge this now!

rbngzlv · 2018-02-22T17:07:15Z

Thanks @josepjaume !

josepjaume · 2018-02-22T17:23:33Z

Thank you for your patience!

ghost assigned rbngzlv Feb 12, 2018

ghost added the in-progress label Feb 12, 2018

rbngzlv force-pushed the feature/meetings-process-home branch from ab5a319 to 200385f Compare February 13, 2018 06:43

mrcasals reviewed Feb 13, 2018

View reviewed changes

josepjaume suggested changes Feb 14, 2018

View reviewed changes

rbngzlv added in-review and removed in-progress labels Feb 16, 2018

rbngzlv and others added 6 commits February 21, 2018 21:59

Add view hooks to particiaptory_processes

e188a47

Add meetings to process and process group home

ecf1e79

Delegate date/time format to i18n

72cdfad

Generalize participatory_space_highlighted_elements view hook

7d226fa

Show meetings before attachments

4d3b546

Add CHANGELOG entries

85840bd

rbngzlv force-pushed the feature/meetings-process-home branch from 776327b to 85840bd Compare February 21, 2018 21:00

Merge branch 'master' into feature/meetings-process-home

6de362c

josepjaume approved these changes Feb 22, 2018

View reviewed changes

josepjaume merged commit 42fdc04 into master Feb 22, 2018

josepjaume deleted the feature/meetings-process-home branch February 22, 2018 17:03

ghost removed the in-review label Feb 22, 2018

xabier mentioned this pull request Feb 22, 2018

Special content can be added to the process or superprocess home #2273

Closed

5 tasks

rbngzlv mentioned this pull request Feb 26, 2018

Add results to process and process group home #2824

Merged

1 task

leio10 mentioned this pull request Mar 25, 2020

Replace current meetings hook with highlighted elements hook #5897

Merged

1 task

Uh oh!

Conversation

rbngzlv commented Feb 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

📋 Subtasks

📷 Screenshots

Uh oh!

codecov bot commented Feb 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mrcasals Feb 13, 2018

Choose a reason for hiding this comment

Uh oh!

mrcasals Feb 13, 2018

Choose a reason for hiding this comment

Uh oh!

josepjaume left a comment

Choose a reason for hiding this comment

Uh oh!

josepjaume Feb 14, 2018

Choose a reason for hiding this comment

Uh oh!

mrcasals Feb 14, 2018

Choose a reason for hiding this comment

Uh oh!

josepjaume Feb 14, 2018

Choose a reason for hiding this comment

Uh oh!

rbngzlv commented Feb 16, 2018

Uh oh!

rbngzlv commented Feb 16, 2018

Uh oh!

xabier commented Feb 18, 2018

Uh oh!

josepjaume commented Feb 20, 2018

Uh oh!

rbngzlv commented Feb 21, 2018

Uh oh!

josepjaume commented Feb 21, 2018

Uh oh!

rbngzlv commented Feb 22, 2018

Uh oh!

rbngzlv commented Feb 22, 2018

Uh oh!

josepjaume left a comment

Choose a reason for hiding this comment

Uh oh!

rbngzlv commented Feb 22, 2018

Uh oh!

josepjaume commented Feb 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rbngzlv commented Feb 12, 2018 •

edited

Loading

codecov bot commented Feb 13, 2018 •

edited

Loading