Conversation
Codecov Report
@@ Coverage Diff @@
## master #2763 +/- ##
==========================================
+ Coverage 98.85% 98.86% +<.01%
==========================================
Files 1534 1537 +3
Lines 36091 36164 +73
==========================================
+ Hits 35679 35752 +73
Misses 412 412 |
65 tasks
oriolgual
approved these changes
Feb 20, 2018
Contributor
oriolgual
left a comment
There was a problem hiding this comment.
Approved but review the comments please
|
|
||
| def i18n_labels_scope | ||
| "activemodel.attributes.static_page" | ||
| end |
Contributor
There was a problem hiding this comment.
Is this expected to be here?
Contributor
Author
There was a problem hiding this comment.
Yes, it is. It's overwriting a method in the BasePresenter, I forgot it in the previous PR and didn't want to create a new one for this :(
| delete: "%{user_name} deleted the %{resource_name} newsletter" | ||
| deliver: "%{user_name} delivered the %{resource_name} newsletter" | ||
| update: "%{user_name} updated the %{resource_name} newsletter" | ||
| static_pages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Logs creation, update, deletion and delivering of newsletters.
Also fixes some problems with the static pages logs.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)