Add Area and AreaType classes and functionality to assign areas to assemblies by isaacmg410 · Pull Request #2750 · decidim/decidim

isaacmg410 · 2018-02-16T11:44:45Z

🎩 What? Why?

Add Area and AreaType and add a select field for assign an area to assemblies

📌 Related Issues

Related to Improvements to Assemblies MVP #2709

📋 Subtasks

mrcasals

Don't forget to add system specs for this, please! 😄

codecov · 2018-02-16T12:38:01Z

Codecov Report

Merging #2750 into master will decrease coverage by 0.01%.
The diff coverage is 97.84%.

@@            Coverage Diff             @@
##           master    #2750      +/-   ##
==========================================
- Coverage   98.86%   98.85%   -0.02%     
==========================================
  Files        1555     1572      +17     
  Lines       36888    37267     +379     
==========================================
+ Hits        36471    36840     +369     
- Misses        417      427      +10

mrcasals · 2018-02-16T13:27:11Z

@isaacmg410 can you add a proper title for this PR?

isaacmg410 · 2018-02-16T13:29:02Z

@mrcasals much better? 😄

mrcasals · 2018-02-16T13:30:01Z

@isaacmg410 yeah, although I don't understand what those numbers mean in the beginning of the title 😄

isaacmg410 · 2018-02-16T13:32:43Z

@mrcasals It was the issue number 😸

isaacmg410 · 2018-02-22T12:39:01Z

@mrcasals admin site is very similar to Scope and ScopeType, and I don't see system specs for these. What should be taken into account for Area and AreaType system spec?

mrcasals · 2018-02-22T13:31:45Z

@isaacmg410 copy how other system specs work, then. You should test the index, create and delete actions, and show if there's any

isaacmg410 · 2018-02-22T14:00:12Z

@mrcasals What can we do with codeclimate errors? it says similiar blocks..

oriolgual · 2018-02-22T14:30:06Z

@isaacmg410 I've marked them as wontfix

…ix locales

isaacmg410 · 2018-02-23T08:43:06Z

system specs area and areatype added on admin 😄

mrcasals · 2018-02-23T09:45:10Z

Going in @isaacmg410! Thank you! 🎉

isaacmg410 · 2018-02-23T09:46:38Z

🎉 🎉

mrcasals · 2018-02-28T13:21:49Z

@isaacmg410 before opening an issue, is there any reason why the area input uses a plain select instead of reusing the data-picker we use in the scopes field? 😕 🤔

mrcasals · 2018-02-28T13:29:05Z

decidim-admin/spec/commands/create_area_type_spec.rb

+require "spec_helper"
+
+module Decidim::Admin
+  describe CreateScopeType do


This test is wrong

mrcasals · 2018-02-28T13:29:16Z

decidim-admin/spec/commands/create_area_spec.rb

+require "spec_helper"
+
+module Decidim::Admin
+  describe CreateScope do


This test is wrong

mrcasals · 2018-02-28T13:29:26Z

decidim-admin/spec/commands/update_area_type_spec.rb

+require "spec_helper"
+
+module Decidim::Admin
+  describe UpdateScopeType do


This test is wrong

mrcasals · 2018-02-28T13:29:53Z

decidim-admin/spec/commands/update_area_spec.rb

+require "spec_helper"
+
+module Decidim::Admin
+  describe UpdateScope do


This test is wrong

mrcasals · 2018-02-28T13:31:13Z

@isaacmg410 see #2856 for more problems related with this PR 😞

isaacmg410 · 2018-02-28T14:46:44Z

@mrcasals about this

@isaacmg410 before opening an issue, is there any reason why the area input uses a plain select instead of reusing the data-picker we use in the scopes field? 😕 🤔

We think that it is not necessary to use scopes_picker_field since there are no child areas. On the other hand, it is an MVP.

mrcasals · 2018-02-28T14:52:58Z

@isaacmg410 oh, OK then.

ghost assigned isaacmg410 Feb 16, 2018

ghost added the in-progress label Feb 16, 2018

mrcasals reviewed Feb 16, 2018

View reviewed changes

isaacmg410 changed the title ~~2709 mvp assemblies improvements area field~~ 2709 Add Area and AreaType classes and functionality to assign areas to assemblies Feb 16, 2018

isaacmg410 changed the title ~~2709 Add Area and AreaType classes and functionality to assign areas to assemblies~~ #2709 Add Area and AreaType classes and functionality to assign areas to assemblies Feb 16, 2018

isaacmg410 changed the title ~~#2709 Add Area and AreaType classes and functionality to assign areas to assemblies~~ Add Area and AreaType classes and functionality to assign areas to assemblies Feb 16, 2018

isaacmg410 force-pushed the 2709_MVP_assemblies_improvements_area_field branch from 6a28d16 to 2a06aec Compare February 22, 2018 12:39

isaacmg410 added in-review and removed in-progress labels Feb 22, 2018

Isaac Massot added 9 commits February 23, 2018 08:35

[WIP] working on areas fields

31f4b0e

create areas and areas types

b652caa

apply areas to assemblies

9b63fef

add changelog

f492956

fix migration

1f300fb

review rubocop errors, add system spec for admin manage scopes, and f…

6cf0732

…ix locales

fix rubocop

f34378f

improve documentation

33a012b

add system specs

54cdf36

isaacmg410 force-pushed the 2709_MVP_assemblies_improvements_area_field branch from 2a06aec to 54cdf36 Compare February 23, 2018 08:42

oriolgual approved these changes Feb 23, 2018

View reviewed changes

mrcasals approved these changes Feb 23, 2018

View reviewed changes

mrcasals merged commit e2699cb into master Feb 23, 2018

ghost removed the in-review label Feb 23, 2018

mrcasals deleted the 2709_MVP_assemblies_improvements_area_field branch February 23, 2018 09:45

mrcasals mentioned this pull request Feb 28, 2018

EPIC: Activity log for administrators, moderators and verifiers #2718

Closed

65 tasks

mrcasals mentioned this pull request Feb 28, 2018

Area and AreaType command specs are actually testing scope commands #2856

Closed

mrcasals reviewed Feb 28, 2018

View reviewed changes

isaacmg410 mentioned this pull request Feb 28, 2018

BUGFIX Area and AreaType command specs #2859

Merged

2 tasks

This was referenced Mar 5, 2018

Add missing i18n in assemblies #2915

Merged

Link to area#show is not working on admin #2943

Closed

mrcasals modified the milestone: Release v.0.10.0 Mar 7, 2018

isaacmg410 mentioned this pull request Mar 7, 2018

Remove the link and the path to view single areas on admin #2945

Merged

2 tasks

This was referenced May 4, 2018

Strange behaviour when creating an area with the same name #3336

Merged

Strange behaviour when creating an area with the same name #3349

Closed

Backport Strange behaviour when creating an area with the same name #3350

Merged

Uh oh!

Conversation

isaacmg410 commented Feb 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

📋 Subtasks

Uh oh!

mrcasals left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mrcasals commented Feb 16, 2018

Uh oh!

isaacmg410 commented Feb 16, 2018

Uh oh!

mrcasals commented Feb 16, 2018

Uh oh!

isaacmg410 commented Feb 16, 2018

Uh oh!

isaacmg410 commented Feb 22, 2018

Uh oh!

mrcasals commented Feb 22, 2018

Uh oh!

isaacmg410 commented Feb 22, 2018

Uh oh!

oriolgual commented Feb 22, 2018

Uh oh!

isaacmg410 commented Feb 23, 2018

Uh oh!

mrcasals commented Feb 23, 2018

Uh oh!

isaacmg410 commented Feb 23, 2018

Uh oh!

mrcasals commented Feb 28, 2018

Uh oh!

mrcasals Feb 28, 2018

Choose a reason for hiding this comment

Uh oh!

mrcasals Feb 28, 2018

Choose a reason for hiding this comment

Uh oh!

mrcasals Feb 28, 2018

Choose a reason for hiding this comment

Uh oh!

mrcasals Feb 28, 2018

Choose a reason for hiding this comment

Uh oh!

mrcasals commented Feb 28, 2018

Uh oh!

isaacmg410 commented Feb 28, 2018

Uh oh!

mrcasals commented Feb 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

isaacmg410 commented Feb 16, 2018 •

edited

Loading

codecov bot commented Feb 16, 2018 •

edited

Loading