Conversation
| decidim-comments (= 0.9.0.pre) | ||
| decidim-core (= 0.9.0.pre) | ||
| kaminari (~> 1.0.1) | ||
| ransack |
There was a problem hiding this comment.
ransack looks nice, maybe we should drop searchlight in favor of it? @deivid-rodriguez @josepjaume @mrcasals
There was a problem hiding this comment.
Looks good to me, although I just gave it a superficial look. Should we open an issue to discuss this?
Codecov Report
@@ Coverage Diff @@
## master #2419 +/- ##
==========================================
- Coverage 98.69% 98.68% -0.01%
==========================================
Files 1296 1296
Lines 30279 30285 +6
==========================================
+ Hits 29883 29887 +4
- Misses 396 398 +2 |
|
Is this PR properly rebased to master? I'm seeing a lot of unrelated changes in GitHub's diff. |
fff5b43 to
7e6ecdd
Compare
|
@josepjaume I'm checking the rebase. Does anyone of @decidim/lot-core can review the comments on this issue and give feedback on how to implement the counter_cache for comments? |
3581efc to
0851e97
Compare
| proposal: | ||
| fields: | ||
| category: Category | ||
| comments: Comments |
There was a problem hiding this comment.
Should this be "Comments count"?
There was a problem hiding this comment.
I've followed the same naming as "votes: Votes". If "Comments count" is prefered I can change
There was a problem hiding this comment.
Ah, I see. Let's leave it as it is then! 😄
|
@isaacmg410 PR looks good, nice job! Can you add a CHANGELOG entry before merging this, please? |
|
@mrcasals changelog entry added. |
oriolgual
left a comment
There was a problem hiding this comment.
Just minor things, nice work!
| helper_method :proposals | ||
| helper_method :proposals, :query | ||
|
|
||
| def index; end |
There was a problem hiding this comment.
Rails doesn't need the action definition is there's already the view file, so we can delete this!
| private | ||
|
|
||
| def query | ||
| @q ||= Proposal.where(feature: current_feature).ransack(params[:q]) |
There was a problem hiding this comment.
Please use @query as a variable name
…idim into 1993_improve_proposals_admin
|
Wohoo! 🎉 💪 |
🎩 What? Why?
📌 Related Issues
📋 Subtasks