decidim-meetings/spec/cells/decidim/meetings/dates_and_map_cell_spec.rb (1)

76-90: Good multi-year coverage, but missing test for nil end_time.

The multi-year test scenario is well-structured. However, unlike the MeetingLCell spec which includes a "when meeting has no end time" context (lines 81-95 in that file), this spec lacks coverage for meetings without an end_time.

Adding this test would help catch the nil guard issue flagged in the DatesAndMapCell review.

📝 Suggested test addition

context "when meeting has no end time" do
  let!(:meeting) { create(:meeting, :published, start_time: Time.new(2020, 10, 15, 10, 0, 0, 0), end_time: nil) }

  it "shows the start time's month" do
    expect(subject).to have_css(".meeting__calendar-month", text: "October")
  end

  it "shows the start time's day" do
    expect(subject).to have_css(".meeting__calendar-day", text: "15")
  end

  it "does not show separator" do
    expect(subject).to have_no_css(".meeting__calendar-separator")
  end
end

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@decidim-meetings/spec/cells/decidim/meetings/dates_and_map_cell_spec.rb`
around lines 76 - 90, The spec is missing coverage for a meeting with a nil
end_time in decidim/meetings/dates_and_map_cell_spec.rb; add a new context "when
meeting has no end time" that creates a published meeting with start_time set
(e.g., Time.new(2020,10,15,10,0,0)) and end_time: nil, then assert via the cell
subject that the start month's and day's elements (".meeting__calendar-month"
and ".meeting__calendar-day") are present and that the separator element
(".meeting__calendar-separator") is not present, mirroring the existing style
used in the other contexts so the DatesAndMapCell rendering handles nil end_time
safely.

decidim-meetings/spec/cells/decidim/meetings/meeting_l_cell_spec.rb (1)

108-110: Tighten the separator assertion to the year block.

This currently passes if any calendar separator exists; scope it to .card__calendar-year to validate the multi-year behavior directly.

Suggested diff

-      it "shows the separator" do
-        expect(subject).to have_css(".card__calendar-separator")
+      it "shows the year separator" do
+        expect(subject).to have_css(".card__calendar-year .card__calendar-separator")
       end

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@decidim-meetings/spec/cells/decidim/meetings/meeting_l_cell_spec.rb` around
lines 108 - 110, The test "it shows the separator" currently checks for any
calendar separator; narrow it to the year block by asserting the separator
exists inside the `.card__calendar-year` element (e.g. expect(subject) to have
CSS selector combining `.card__calendar-year` and `.card__calendar-separator`),
so update the assertion in the example that defines the subject to look for
`.card__calendar-year .card__calendar-separator` instead of just
`.card__calendar-separator`.