Walkthrough

Removes announcement fields from assemblies and participatory processes and moves announcement content into content blocks: deletes form fields, serializers, GraphQL fields and importer/duplication assignments; adds content-block settings, UI cell, migrations to migrate existing announcements; updates tests accordingly.

Changes

Sequence Diagram(s)

sequenceDiagram
  participant Admin as Admin UI
  participant Cell as AnnouncementSettingsFormCell
  participant ContentBlock as Decidim::ContentBlock
  participant DB as Database / Migration
  participant API as Serializer / GraphQL

  Admin->>Cell: open/edit announcement settings form
  Cell->>ContentBlock: read/update settings[:announcement_<locale>]
  ContentBlock->>DB: save settings (persist per-locale announcement keys)
  DB->>ContentBlock: migration MoveAnnouncementToContentBlock... moves model.announcement -> settings keys
  ContentBlock->>API: serializers/GraphQL read announcement from settings (not model field)
  API-->>Admin: announcement displayed via content block in front-end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Show a warning message when the space images URL have errors #16026: Also modifies assembly_importer and image/import handling — overlaps with announcement import changes.
• Add cop rule for bad usage of have_admin_callout #16011: Related test refactors and replacement of generic admin callout expectations.
• Clean-up the old partial/cells on navigation menu #15862: Related UI/cell changes (breadcrumb/dropdown adjustments) that overlap with view-cell refactors.

Suggested reviewers

• alecslupu

Poem

🐰
I hopped from form to block with glee,
Took the announcement where it should be.
Now admins edit, position, and see—
One place for note, neat as can be. ✨

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

decidim-assemblies/spec/shared/assembly_announcements_examples.rb (1)

16-26: Duplicated helper and potential slow has_css? check.

Two observations:

1. This fill_announcement_editor method is identical to the one in decidim-participatory_processes/spec/shared/process_announcements_examples.rb. Consider extracting it into a shared support helper (e.g., a module in decidim-admin/spec/support/) to keep the two in sync.

2. page.has_css?(...) waits up to the full Capybara default timeout before returning false. If the tabs element is frequently absent, this silently adds seconds to each test run. Passing wait: 0 (or a short timeout) avoids that:

♻️ Suggested tweak

-    if page.has_css?("#content_block-settings--announcement-tabs")
+    if page.has_css?("#content_block-settings--announcement-tabs", wait: 0)

decidim-participatory_processes/spec/shared/process_announcements_examples.rb (2)

16-38: has_css? branching will incur Capybara's default wait time on the negative path.

When the #content_block-settings--announcement-tabs element doesn't exist, page.has_css? will wait for the full Capybara.default_max_wait_time before returning false, slowing down each test that hits the else branch. Consider using has_css?(..., wait: 0) or has_css?(..., wait: 1) if you just need a quick presence check for branching.

♻️ Reduce wait time on the branching check

 def fill_announcement_editor(values)
-    if page.has_css?("#content_block-settings--announcement-tabs")
+    if page.has_css?("#content_block-settings--announcement-tabs", wait: 0)
       fill_in_i18n_editor(

 def clear_announcement_editor(locales)
-    if page.has_css?("#content_block-settings--announcement-tabs")
+    if page.has_css?("#content_block-settings--announcement-tabs", wait: 0)
       clear_i18n_editor(

---

67-87: Missing post-save assertion after click_on "Update".

The first test (Line 51) asserts have_content("Active content blocks") after saving, confirming the update succeeded. This test skips that check, so a silent save failure would go unnoticed and the subsequent frontend assertions could pass vacuously (e.g., no announcement displayed simply because it was never saved).

♻️ Add a post-save assertion for consistency

     click_on "Update"
+    expect(page).to have_content("Active content blocks")

     visit decidim_admin_participatory_processes.participatory_processes_path

• X
• Mastodon
• Reddit
• LinkedIn