Skip to content

Fix decidim dev tasks not being exposed#1554

Merged
beagleknight merged 3 commits intomasterfrom
fix/dev_tasks_not_exposed
Jul 10, 2017
Merged

Fix decidim dev tasks not being exposed#1554
beagleknight merged 3 commits intomasterfrom
fix/dev_tasks_not_exposed

Conversation

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez commented Jun 30, 2017

🎩 What? Why?

Since #1527, decidim-dev's railtie was not being required. That means its tasks decidim:check_locales and decidim:generate_test_app were no longer being exposed to the application.

This change fixes it.

It also stops exposing some "app only tasks" that don't make sense in the development repo side.

Before (in main repo):

$ bundle exec rake -T decidim
rake decidim:check_locales      # Allows a decidim installation to check whether its locales are complete
rake decidim:generate_test_app  # Generates a dummy app for testing
rake decidim:upgrade            # Install migrations from Decidim to the app

Before (in end application):

$ bundle exec rake -T decidim
rake decidim:install:migrations            # Copy migrations from decidim to application
rake decidim:upgrade                       # Install migrations from Decidim to the app
rake decidim_admin:install:migrations      # Copy migrations from decidim_admin to application
rake decidim_budgets:install:migrations    # Copy migrations from decidim_budgets to application
rake decidim_comments:install:migrations   # Copy migrations from decidim_comments to application
rake decidim_meetings:install:migrations   # Copy migrations from decidim_meetings to application
rake decidim_pages:install:migrations      # Copy migrations from decidim_pages to application
rake decidim_proposals:install:migrations  # Copy migrations from decidim_proposals to application
rake decidim_results:install:migrations    # Copy migrations from decidim_results to application
rake decidim_surveys:install:migrations    # Copy migrations from decidim_surveys to application
rake decidim_system:install:migrations     # Copy migrations from decidim_system to application

After (in main repo):

$ bundle exec rake -T decidim
rake decidim:generate_test_app  # Generates a dummy app for testing

After (in end application):

$ bundle exec rake -T decidim
rake decidim:check_locales                 # Allows a decidim installation to check whether its locales are complete
rake decidim:generate_test_app             # Generates a dummy app for testing
rake decidim:install:migrations            # Copy migrations from decidim to application
rake decidim:upgrade                       # Install migrations from Decidim to the app
rake decidim_admin:install:migrations      # Copy migrations from decidim_admin to application
rake decidim_budgets:install:migrations    # Copy migrations from decidim_budgets to application
rake decidim_comments:install:migrations   # Copy migrations from decidim_comments to application
rake decidim_meetings:install:migrations   # Copy migrations from decidim_meetings to application
rake decidim_pages:install:migrations      # Copy migrations from decidim_pages to application
rake decidim_proposals:install:migrations  # Copy migrations from decidim_proposals to application
rake decidim_results:install:migrations    # Copy migrations from decidim_results to application
rake decidim_surveys:install:migrations    # Copy migrations from decidim_surveys to application
rake decidim_system:install:migrations     # Copy migrations from decidim_system to application

📌 Related Issues

None.

📋 Subtasks

None.

📷 Screenshots (optional)

None.

👻 GIF

food

@deivid-rodriguez
Fix decidim dev tasks not being exposed to end app
774cfd7 
Decidim railtie was not being required. That meant its tasks
`decidim:check_locales` and `decidim:generate_test_app` were not being
exposed to the application.

This change fixes it.
@deivid-rodriguez
Fix decidim-dev tasks exposed to main repo
1418b1c 
The task `decidim:check_locales` does not make sense here.
@deivid-rodriguez
Don't load unnecessary task
ec6583f 
The `decidim:upgrade` task only makes sense inside an application.
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 30, 2017

Codecov Report

Merging #1554 into master will decrease coverage by 6.5%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1554      +/-   ##
==========================================
- Coverage   97.01%   90.51%   -6.51%     
==========================================
  Files         495      352     -143     
  Lines        8434     5838    -2596     
==========================================
- Hits         8182     5284    -2898     
- Misses        252      554     +302

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 30, 2017 •
edited
Loading

Codecov Report

Merging #1554 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1554   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         495      495           
  Lines        8434     8434           
=======================================
  Hits         8182     8182           
  Misses        252      252

@deivid-rodriguez deivid-rodriguez mentioned this pull request Jun 30, 2017
Merged
beagleknight
beagleknight approved these changes Jul 10, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@beagleknight beagleknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! :)

josepjaume
josepjaume approved these changes Jul 10, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@josepjaume josepjaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uber nice!

@josepjaume josepjaume modified the milestone: 0.5.0 Jul 10, 2017
@mention-bot
Copy link
Copy Markdown

mention-bot commented Jul 10, 2017

@deivid-rodriguez, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mrcasals and @josepjaume to be potential reviewers.

@beagleknight beagleknight merged commit 2523206 into master Jul 10, 2017
@beagleknight beagleknight deleted the fix/dev_tasks_not_exposed branch July 10, 2017 08:37
leio10 pushed a commit to podemos-info/decidim that referenced this pull request Jul 26, 2017
@deivid-rodriguez @leio10
Fix decidim dev tasks not being exposed (decidim#1554)
b10fea3 
* Fix decidim dev tasks not being exposed to end app

Decidim railtie was not being required. That meant its tasks
`decidim:check_locales` and `decidim:generate_test_app` were not being
exposed to the application.

This change fixes it.

* Fix decidim-dev tasks exposed to main repo

The task `decidim:check_locales` does not make sense here.

* Don't load unnecessary task

The `decidim:upgrade` task only makes sense inside an application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@beagleknight beagleknight beagleknight approved these changes

@josepjaume josepjaume josepjaume approved these changes

@mrcasals mrcasals mrcasals approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@deivid-rodriguez deivid-rodriguez

Labels

None yet

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@deivid-rodriguez @mention-bot @beagleknight @josepjaume @mrcasals @ItsGenis