Implement hamburger menu #15132
Merged
alecslupu merged 8 commits intodecidim:feature/remove-menu-entriesfrom Oct 8, 2025
Merged
Implement hamburger menu #15132alecslupu merged 8 commits intodecidim:feature/remove-menu-entriesfrom
alecslupu merged 8 commits intodecidim:feature/remove-menu-entriesfrom
Conversation
06a8f23 to
e118ea4
Compare
a48d691 to
6f40b06
Compare
6f40b06 to
7df5034
Compare
7df5034 to
894eb89
Compare
894eb89 to
6fefcd4
Compare
andreslucena
reviewed
Oct 6, 2025
andreslucena
reviewed
Oct 6, 2025
andreslucena
reviewed
Oct 6, 2025
| & > span, | ||
| & > svg:first-of-type { | ||
| @apply text-gray-8; | ||
| @apply block #{!important}; |
Member
There was a problem hiding this comment.
Same with this and the one on line 483
If it is necessary, then it is better to just use plain CSS and not mix tailwind's apply with important
Suggested change
| @apply block #{!important}; | |
| display: block !important; |
andreslucena
reviewed
Oct 6, 2025
Comment on lines
+60
to
+61
| 5: "#E9E9E9", | ||
| 6: "#FAFAFA" |
Member
There was a problem hiding this comment.
I think the background-6 isn't actually being used.
Suggested change
| 5: "#E9E9E9", | |
| 6: "#FAFAFA" | |
| 5: "#E9E9E9" |
andreslucena
reviewed
Oct 6, 2025
andreslucena
reviewed
Oct 6, 2025
andreslucena
reviewed
Oct 6, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
@alecslupu FYI apart from the issues that I commented here, I also have found some issues that I'm tracking at #15299 (feel free to ignore them for now or tackle theme here, whatever you prefer)
andreslucena
requested changes
Oct 7, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
Just talked with @julietapasetti to clarify what shall we do with the colors, can you check them out please? If it's too hassle to handle because of all the PRs and branches in parallel we can handle it on #15299
fix lint issues Fix some failing specs Remove duplicate tags
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
56882ec to
009e5ce
Compare
Contributor
Author
|
@andreslucena Here i would like to make sure we merge everything in one single, PR ( #15134 ), then i will handle those 50 Shades ... and also the issues form the support ticket. |
443e31f
into
decidim:feature/remove-menu-entries
73 of 75 checks passed
andreslucena
added a commit
that referenced
this pull request
Nov 18, 2025
* Remove Help, Meetings, and Activity from the header navigation Remove unused locale Patch the menu * Implement breadcrumb navigation (#15141) Co-authored-by: MariaDascaluPublicis <166501615+MariaDascaluPublicis@users.noreply.github.com> * Remove the "Global menu" content block (#15135) Co-authored-by: Tom Greenwood <tom.t.greenwood@gmail.com> * Implement hamburger menu (#15132) Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: MariaDascaluPublicis <maria.dascalu@publicissapient.com> * Add language chooser to header (#15365) Co-authored-by: MariaDascaluPublicis <166501615+MariaDascaluPublicis@users.noreply.github.com> Co-authored-by: MariaDascaluPublicis <maria.dascalu@publicissapient.com> * Fix header redesign found issues (#15434) Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Add breadcrumb to menu (#15507) * Add breadcrumb to accountability * Add breadcrumb to blogs * Add breadcrumb to debates * Add breadcrumb to collaborative_texts * Add breadcrumb to elections * Add breadcrumb to surveys * Add breadcrumb to sortitions * Add breadcrumb to proposals * Add breadcrumb to meetings * Fix routing errors * Revert changes on sortitions to avoid conflicts --------- Co-authored-by: MariaDascaluPublicis <166501615+MariaDascaluPublicis@users.noreply.github.com> Co-authored-by: Tom Greenwood <tom.t.greenwood@gmail.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: MariaDascaluPublicis <maria.dascalu@publicissapient.com>
This was referenced Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Introduce a hamburger menu for desktop viewports that consolidates navigation items into a collapsible panel. This menu would behave similarly to the mobile version:
Figma file
📌 Related Issues
Testing