Add Rails 7.2 framework defaults file#14829
Conversation
andreslucena
left a comment
There was a problem hiding this comment.
LGTM! I think this will be much easier than the 7.1 defaults. @alecslupu go ahead and let's uncomment these.
If you want you can do all the new defaults at the same time (as they're only 5, so it should be easy to rollback and try each of those if we see any tricky CI failure). Or if you want to be conservative we can do each of these by commit and see the CI result. Whatever you prefer I'm OK with that.
a8f5ca4
andreslucena
left a comment
There was a problem hiding this comment.
I'm OK with all the changes!
Please, let's:
- Remove the new framework defaults file
- Update the load_defaults to 7.2 in Releases Notes for existing apps
- Remove the change of load_defaults in the generator
Feel free to implement those changes in this PR or in a new one after merging this one @alecslupu
Merging with Codecov Failure. |
🎩 What? Why?
This PR adds
new_framework_defaults_7_2.rband a ActiveStorage migration file.📌 Related Issues
Link your PR to an issue
Testing
Green piepeline.
📷 Screenshots
Please add screenshots of the changes you are proposing
