Conversation
LINE 1: ..."decidim_users"."type" = $1 AND (extended_data @> {"ephemera...
…im_action_logs"."resource_id" = $2 AND (extra @> {"edit":tr...
…ings->'global'->>'geocoding_enabled')::boolean is $3 or mani...
… relation "active_storage_attachments" violates not-null constraint
…t `state` is not an attribute. Use `alias_method :internal_state, :state` or define the method manually. (ArgumentError)
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
|
@andreslucena , as of 999a673 we have a green pipeline. I went ahead and merged branch suggestions. |
andreslucena
left a comment
There was a problem hiding this comment.
Great! Seems like the releases notes for v7.1 to v7.2 are much shorter than the v7.0 to v7.1 update!!
I tried the happy paths and it worked well:
- updating an existing development_app from develop (v7.1) to this branch (v7.2)
- creating a new development_app
Both of these work.
I'll give you some feedback on missing things that we should do. We can do them in another PR if you want, but I'm leaving this in one place so I don't miss them, as they're lots of small things:
- update @rails/ujs to latest compatible version: https://www.npmjs.com/package/@rails/ujs/v/7.1.501 (there isn't a 7.2 version as far as I see)
- update @rails/activestorage to latest compatible version: https://www.npmjs.com/package/@rails/activestorage/v/7.2.201
- add the
new_framework_defaults_7_2.rbfile, so we have the backlog for the next PR (changing defaults from 7.1 to 7.2) - while reading about this update, I found out about the change with the development secrets that we talked in #13267. I'd recommend renaming the file in our Releases Notes:
Line 81 in 5cea8a4
- while reading the Releases Notes, I saw that we're mentioning that implementers should remove the decidim initializer but we're still generating it for new apps. We should remove that from the generator
Line 38 in 5cea8a4
- another pending thing related to the Env Vars/initailizer/secrets change is this clean-up #14446
As I mentioned, I'm ok with merging this as is (as long as you agree with removing these https://github.com/decidim/decidim/pull/14784/files#r2126005712 😄), and do the other changes in other PRs, as they're slightly related to the v7.2 change but as the pipeline is green and the happy path work correctly, then I don't want to block this
andreslucena
left a comment
There was a problem hiding this comment.
Merging this as I'm OK with the current status.
I created an issue to keep track of the pending changes: #14804
🎩 What? Why?
This PR updates Decidim to rails 7.2.
There is no RELEASE_NOTES information, as this PR works with Rails 7.1 defaults, and will have 2 additional PR that will follow:
📌 Related Issues
Link your PR to an issue
Testing