Skip to content

Update Rails to v7.2#14784

Merged
andreslucena merged 23 commits intodevelopfrom
chore/rails-7.2
Jun 4, 2025
Merged

Update Rails to v7.2#14784
andreslucena merged 23 commits intodevelopfrom
chore/rails-7.2

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Jun 2, 2025

🎩 What? Why?

This PR updates Decidim to rails 7.2.
There is no RELEASE_NOTES information, as this PR works with Rails 7.1 defaults, and will have 2 additional PR that will follow:

  • Rails 7.2 defaults ( when the RELEASE_NOTES will be altered )
  • Fixes for the enum deprecations

📌 Related Issues

Link your PR to an issue

Testing

  1. Green pipeline

♥️ Thank you!

@github-actions github-actions bot added module: core dependencies Pull requests that update a dependency file or issues that talk about updating dependencies module: generators type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Jun 2, 2025
github-actions[bot]
github-actions bot previously approved these changes Jun 2, 2025
github-actions[bot]
github-actions bot previously approved these changes Jun 2, 2025
github-actions[bot]
github-actions bot previously approved these changes Jun 2, 2025
alecslupu added 2 commits June 2, 2025 14:41
            LINE 1: ..."decidim_users"."type" = $1 AND (extended_data @> {"ephemera...
…im_action_logs"."resource_id" = $2 AND (extra @> {"edit":tr...
github-actions[bot]
github-actions bot previously approved these changes Jun 2, 2025
github-actions[bot]
github-actions bot previously approved these changes Jun 2, 2025
alecslupu added 2 commits June 2, 2025 16:08
… relation "active_storage_attachments" violates not-null constraint
…t `state` is not an attribute. Use `alias_method :internal_state, :state` or define the method manually. (ArgumentError)
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Jun 3, 2025
github-actions[bot]
github-actions bot previously approved these changes Jun 3, 2025
github-actions[bot]
github-actions bot previously approved these changes Jun 3, 2025
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Jun 3, 2025
@alecslupu
Copy link
Copy Markdown
Contributor Author

@andreslucena , as of 999a673 we have a green pipeline. I went ahead and merged branch suggestions.

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Seems like the releases notes for v7.1 to v7.2 are much shorter than the v7.0 to v7.1 update!!

I tried the happy paths and it worked well:

  1. updating an existing development_app from develop (v7.1) to this branch (v7.2)
  2. creating a new development_app

Both of these work.

I'll give you some feedback on missing things that we should do. We can do them in another PR if you want, but I'm leaving this in one place so I don't miss them, as they're lots of small things:

As I mentioned, I'm ok with merging this as is (as long as you agree with removing these https://github.com/decidim/decidim/pull/14784/files#r2126005712 😄), and do the other changes in other PRs, as they're slightly related to the v7.2 change but as the pipeline is green and the happy path work correctly, then I don't want to block this

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this as I'm OK with the current status.

I created an issue to keep track of the pending changes: #14804

@andreslucena andreslucena merged commit a6e0dec into develop Jun 4, 2025
122 checks passed
@andreslucena andreslucena deleted the chore/rails-7.2 branch June 4, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file or issues that talk about updating dependencies module: ai module: blogs module: comments module: core module: dev module: generators module: initiatives module: proposals type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants