Merged
Conversation
alecslupu
suggested changes
Jan 13, 2025
Contributor
There was a problem hiding this comment.
While trying this PR i have noticed the following error. If this error gets fixed, this PR can get merged:
NoMethodError (undefined method `manifest' for an instance of Decidim::CoreDataManifest):
20:00:53 sidekiq.1 | /home/alecslupu/Sites/decidim/redesign/decidim-core/app/services/decidim/open_data_exporter.rb:72:in `data_for_resource'
20:00:53 sidekiq.1 | /home/alecslupu/Sites/decidim/redesign/decidim-core/app/services/decidim/open_data_exporter.rb:34:in `export'
20:00:53 sidekiq.1 | /home/alecslupu/Sites/decidim/redesign/decidim-core/app/jobs/decidim/open_data_job.rb:11:in `perform'
20:00:53 sidekiq.1 | /home/alecslupu/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/activejob-7.0.8.4/lib/active_job/execution.rb:65:in `block in _perform_job'
Applying this patch fixes the error:
diff --git a/decidim-core/app/services/decidim/open_data_exporter.rb b/decidim-core/app/services/decidim/open_data_exporter.rb
index 6dad5d9d33..86c2186dc8 100644
--- a/decidim-core/app/services/decidim/open_data_exporter.rb
+++ b/decidim-core/app/services/decidim/open_data_exporter.rb
@@ -69,7 +69,7 @@ module Decidim
export_manifest = (core_data_manifests + open_data_component_manifests + open_data_participatory_space_manifests)
.select { |manifest| manifest.name == resource.to_sym }.first
- case export_manifest.manifest
+ case export_manifest.respond_to?(:manifest) && export_manifest.manifest
when Decidim::ComponentManifest
data_for_component(export_manifest).read
when Decidim::ParticipatorySpaceManifest
9 tasks
Member
Author
rsdeus
pushed a commit
to octree-gva/decidim
that referenced
this pull request
Jan 15, 2025
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
andreslucena
added a commit
that referenced
this pull request
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR adds the Taxonomies to the Open Data files.
📌 Related Issues
Testing