Skip to content

Documentation: Add system article and updated screenshots#13615

Merged
andreslucena merged 7 commits intodecidim:developfrom
paulinebessoles:feature/add_system_panel_documentation
Dec 20, 2024
Merged

Documentation: Add system article and updated screenshots#13615
andreslucena merged 7 commits intodecidim:developfrom
paulinebessoles:feature/add_system_panel_documentation

Conversation

@paulinebessoles
Copy link
Copy Markdown
Contributor

@paulinebessoles paulinebessoles commented Nov 6, 2024

🎩 What? Why?

This PR is related to the documentation update.
We want to move the System panel documentation article from the "Admin" doc section to the "Configure" doc section.
The admin section is related to the decidim/documentation repo, and the configure one is in this repo docs.

🎩 Left to do

  • Update panel screenshot for an empty panel
  • Update documentation (add Mime types section & CSP sections)

📌 Related Issues

Link your PR to an issue

Testing

Test that images are well displayed on the article once deployed.

♥️ Thank you!

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@paulinebessoles paulinebessoles changed the title Add system article and updated screenshots Feature: Add system article and updated screenshots Nov 6, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 7, 2024
@andreslucena andreslucena changed the title Feature: Add system article and updated screenshots Documentation: Add system article and updated screenshots Dec 11, 2024
@andreslucena
Copy link
Copy Markdown
Member

@paulinebessoles let me know when this is ready for a review

github-actions[bot]
github-actions bot previously approved these changes Dec 13, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 13, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 13, 2024
@paulinebessoles paulinebessoles marked this pull request as ready for review December 13, 2024 16:16
@paulinebessoles
Copy link
Copy Markdown
Contributor Author

@andreslucena this is ready for review!

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor details to change, can you check them out?

@andreslucena andreslucena self-assigned this Dec 15, 2024
@andreslucena
Copy link
Copy Markdown
Member

@paulinebessoles also there are some codeclimate issues (trailing whitespaces) https://codeclimate.com/github/decidim/decidim/pull/13615

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Dec 18, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 18, 2024
@andreslucena andreslucena merged commit 9039fc7 into decidim:develop Dec 20, 2024
mllocs pushed a commit that referenced this pull request Jan 9, 2025
* Add system article and updated screenshots

* Update system article and fix errors

* Fix lint errors

* Fix errors

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Fix codeclimate and typo

* Fix remaining trailing whitespaces

---------

Co-authored-by: paulinebessoles <pauline.bessoles@opensourcepolitics.eu>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants