Combine Functionality for Members and Private Participants in Assemblies#13502
Merged
Combine Functionality for Members and Private Participants in Assemblies#13502
Conversation
4de0889 to
5c8023e
Compare
Contributor
Author
|
|
mllocs
commented
Oct 10, 2024
decidim-admin/app/controllers/decidim/admin/concerns/has_private_users.rb
Show resolved
Hide resolved
bdaa756 to
f195302
Compare
…blic page in assemblies and processes to use the PrivateUser model
Contributor
|
@mllocs Can you fix the failing pipelines? Also, sync with latest develop to make sure we do not have pipeline issues after merging :) |
Contributor
Author
@alecslupu Done! |
alecslupu
approved these changes
Dec 12, 2024
...s/app/views/decidim/participatory_processes/participatory_space_private_users/index.html.erb
Show resolved
Hide resolved
...s/app/views/decidim/participatory_processes/participatory_space_private_users/index.html.erb
Show resolved
Hide resolved
furilo
approved these changes
Dec 12, 2024
Contributor
|
@NilHomedes nevermind the review request |
antopalidi
pushed a commit
that referenced
this pull request
Dec 16, 2024
…ies (#13502) Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
This was referenced Dec 3, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Is your feature request related to a problem? Please describe. Currently, there are two functionalities that overlap in some aspects and can be confusing: Private participants and members. This is because most of the time, members and private participants coincide. It is not useful to have the list of members unlinked to the access permissions for that private space; often this means having to upload the same list of participants twice.
📌 Related Issues
Fixes #13414
Testing
When I want to define an Assembly or Process as private then I see an info message below the checkbox saying that:
”You'll be able to manage private participants after setting it as private.” https://decidim-lot2.populate.tools/admin/assemblies/test/edit
Given I'm an admin, When I define an Assembly or Process as private, Then the "Private participants" element menu appears in the lateral menu. https://decidim-lot2.populate.tools/admin/assemblies/test/participatory_space_private_users
Given I’m an admin in a private space, When I want to add a new Private Participant Then I should fill a form with: Mail, Name and Role (Mail and Name are compulsory) https://decidim-lot2.populate.tools/admin/assemblies/test/participatory_space_private_users/new
Given I’m an admin in a private space, When I fill the form to add a new Private Participant Then I can mark a checkbox to publish that Private Participant. https://decidim-lot2.populate.tools/admin/assemblies/test/participatory_space_private_users/new
Given I’m an admin When the first Private Participant is published Then the "Private Participants" page is automatically published. https://decidim-lot2.populate.tools/assemblies/test/members
Given I'm an admin in a private space, When I have uploaded “Private participants” Then I can publish or unpublish all the private participants by clicking into a button. https://decidim-lot2.populate.tools/admin/assemblies/test/participatory_space_private_users
📷 Screenshots