Map the redis port for the test app actions#13194
Merged
andreslucena merged 2 commits intodecidim:developfrom Jul 23, 2024
Merged
Map the redis port for the test app actions#13194andreslucena merged 2 commits intodecidim:developfrom
andreslucena merged 2 commits intodecidim:developfrom
Conversation
andreslucena
approved these changes
Jul 23, 2024
Member
andreslucena
left a comment
There was a problem hiding this comment.
Makes sense, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
I received the following error in a recent action run:
Whole logs available at:
https://github.com/decidim/decidim/actions/runs/10042209706/job/27752308455?pr=12576
I think this is related to the fact that the Redis port is not mapped to the host machine because Redis should take care of keeping a list of reserved ports (although conflicts are still possible if the port resolution happens exactly at the same time.
Also I marked the Redis port to be skipped in order to keep that reserved for Redis.
📌 Related Issues
Testing
I don't think there is an easy way to test this other than trying to re-introduce a port conflict which requires running the workflows several times.