Skip to content

Map the redis port for the test app actions#13194

Merged
andreslucena merged 2 commits intodecidim:developfrom
mainio:fix/gha-redis-port
Jul 23, 2024
Merged

Map the redis port for the test app actions#13194
andreslucena merged 2 commits intodecidim:developfrom
mainio:fix/gha-redis-port

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

🎩 What? Why?

I received the following error in a recent action run:

#<Thread:0x00007f0b1b1519e0 /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/capybara-3.40.0/lib/capybara/server.rb:76 run> terminated with exception (report_on_exception is true):
/opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/puma-6.4.2/lib/puma/binder.rb:334:in initialize': Address already in use - bind(2) for "127.0.0.1" port 6242 (Errno::EADDRINUSE) from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/puma-6.4.2/lib/puma/binder.rb:334:in new'
from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/puma-6.4.2/lib/puma/binder.rb:334:in add_tcp_listener' from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/puma-6.4.2/lib/puma/binder.rb:163:in block in parse'
from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/puma-6.4.2/lib/puma/binder.rb:146:in each' from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/puma-6.4.2/lib/puma/binder.rb:146:in parse'
from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/capybara-3.40.0/lib/capybara/registrations/servers.rb:63:in block (2 levels) in <top (required)>' from <internal:kernel>:90:in tap'
from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/capybara-3.40.0/lib/capybara/registrations/servers.rb:62:in block in <top (required)>' from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/capybara-3.40.0/lib/capybara/config.rb:64:in block in server='
from /opt/hostedtoolcache/Ruby/3.2.2/x64/lib/ruby/gems/3.2.0/gems/capybara-3.40.0/lib/capybara/server.rb:77:in `block in boot'

Whole logs available at:
https://github.com/decidim/decidim/actions/runs/10042209706/job/27752308455?pr=12576

I think this is related to the fact that the Redis port is not mapped to the host machine because Redis should take care of keeping a list of reserved ports (although conflicts are still possible if the port resolution happens exactly at the same time.

Also I marked the Redis port to be skipped in order to keep that reserved for Redis.

📌 Related Issues

Testing

I don't think there is an easy way to test this other than trying to re-introduce a port conflict which requires running the workflows several times.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@ahukkanen ahukkanen added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Jul 22, 2024
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the PR!

@andreslucena andreslucena merged commit 9b83145 into decidim:develop Jul 23, 2024
@ahukkanen ahukkanen deleted the fix/gha-redis-port branch July 23, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration module: dev type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants