Use redis in CI to prevent conflicting/reserved capybara ports#12705
Merged
alecslupu merged 1 commit intodecidim:developfrom May 3, 2024
Merged
Conversation
alecslupu
approved these changes
May 3, 2024
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
I have tried to replicate on my Local, but no success. Reading the code, i could not find anything wrong with the logic.
LGTM.
andreslucena
pushed a commit
that referenced
this pull request
May 9, 2024
This was referenced May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Capybara server sometimes fails to start due to a reserved port.
This is because the Rails server takes a while to start and when the Capybara setup is checking whether the port is reserved, it fails to do so because the server did not yet have enough time to start.
This PR adds the Redis service to the
test_apppipeline to utilize a central database for all specs to store which ports are reserved.📌 Related Issues
Testing
parallel_testwith Redis running in the background -> expect less issues with reserved portsIf you run
parallel_testwithout Redis, expect to see the same issue as so far occasionally.