Skip to content

Blog post spacing between buttons#12588

Merged
andreslucena merged 11 commits intodecidim:developfrom
greenwoodt:fix/blog-view-spacing
Mar 13, 2024
Merged

Blog post spacing between buttons#12588
andreslucena merged 11 commits intodecidim:developfrom
greenwoodt:fix/blog-view-spacing

Conversation

@greenwoodt
Copy link
Copy Markdown
Member

🎩 What? Why?

Spacing between comments and likes was too small of a gap. I have increased the spacing to that of Proposals to 2.5rem.

📌 Related Issues

Testing

  1. Head over to a Decidim Installation and find process with blog posts.
  2. Click a blog.
  3. See the spacing has increased between the comments and likes.

📷 Screenshots

BEFORE:
Screenshot 2024-03-13 at 08 25 56

AFTER:
Screenshot 2024-03-13 at 08 22 42

♥️ Thank you!

github-actions[bot]

This comment was marked as resolved.

github-actions[bot]

This comment was marked as resolved.

@greenwoodt greenwoodt added type: fix PRs that implement a fix for a bug and removed type: bug labels Mar 13, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 13, 2024
@greenwoodt greenwoodt requested a review from a team March 13, 2024 07:54
@andreslucena andreslucena self-assigned this Mar 13, 2024
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we're adding the top and bottom padding, and I think that only with the top padding is enough.

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@greenwoodt
Copy link
Copy Markdown
Member Author

I see that we're adding the top and bottom padding, and I think that only with the top padding is enough.

Thats fine. I thought perhaps bottom might wanted to be addressed also.

Committed your suggestion

@greenwoodt greenwoodt requested a review from andreslucena March 13, 2024 12:24
@andreslucena andreslucena merged commit c3b78d7 into decidim:develop Mar 13, 2024
@alecslupu alecslupu added the no-backport Pull Requests that should not be backported label Mar 14, 2024
@alecslupu
Copy link
Copy Markdown
Contributor

Adding no-backport as we do not want it in 0.27.x ( at least not with the redesign css )

andreslucena added a commit that referenced this pull request May 9, 2024
* extration of not_hidden method from proposal applied to debates includer method helper in controller

* returned to normal

* Adding spacing top & bottom 2.5rem

* Update decidim-blogs/app/packs/stylesheets/blogs.scss

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: blogs no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Misaligned like and comment buttons on blog page

3 participants