Redesign: Decidim Design Guide translation page (author)#12577
Merged
alecslupu merged 13 commits intodecidim:developfrom Mar 15, 2024
Merged
Redesign: Decidim Design Guide translation page (author)#12577alecslupu merged 13 commits intodecidim:developfrom
alecslupu merged 13 commits intodecidim:developfrom
Conversation
…der method helper in controller
andreslucena
previously requested changes
Mar 8, 2024
Member
andreslucena
left a comment
There was a problem hiding this comment.
Missing translations from helper, can you check it out please?
decidim-design/app/helpers/decidim/design/author_helper.rb
Member
|
Also there's a i18n spec error that you need to fix |
Member
Author
This page is still in progress. I will alert you for another review once it is completed. |
Member
Author
|
@andreslucena this one should be ready to review also. |
20 tasks
alecslupu
suggested changes
Mar 13, 2024
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
@greenwoodt , We are almost there, but some changes are required.
Member
Author
Changes made, ready for another review. |
I am taking over reviewing this PR.
andreslucena
pushed a commit
that referenced
this pull request
May 9, 2024
* extration of not_hidden method from proposal applied to debates includer method helper in controller * returned to normal * title of page added * subtitles of each section added+ * translations complete for each subsection * review changed made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Decidim Design translations for the Author section.
📌 Related Issues
Testing
📷 Screenshots