Redesign: Decidim Design Guide translation page (announcement)#12573
Merged
alecslupu merged 29 commits intodecidim:developfrom Mar 15, 2024
Merged
Redesign: Decidim Design Guide translation page (announcement)#12573alecslupu merged 29 commits intodecidim:developfrom
alecslupu merged 29 commits intodecidim:developfrom
Conversation
…der method helper in controller
20 tasks
…eenwoodt/decidim into fix/design-module-translations/part-9
Member
Author
|
@andreslucena checks passed. |
alecslupu
suggested changes
Mar 13, 2024
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
Some changes, and i would be good to go
decidim-design/app/helpers/decidim/design/announcement_helper.rb
Outdated
Show resolved
Hide resolved
decidim-design/app/helpers/decidim/design/announcement_helper.rb
Outdated
Show resolved
Hide resolved
decidim-design/app/helpers/decidim/design/announcement_helper.rb
Outdated
Show resolved
Hide resolved
decidim-design/app/helpers/decidim/design/announcement_helper.rb
Outdated
Show resolved
Hide resolved
…eenwoodt/decidim into fix/design-module-translations/part-9
Member
Author
Thanks Alex. Should be ready for another review. |
alecslupu
suggested changes
Mar 14, 2024
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
One small change, and we are good to go.
decidim-design/app/helpers/decidim/design/announcement_helper.rb
Outdated
Show resolved
Hide resolved
The requested changes have been applied.
andreslucena
added a commit
that referenced
this pull request
May 9, 2024
* extration of not_hidden method from proposal applied to debates includer method helper in controller * returned to normal * title translated * accouncement description * translations added to the callout class section * missing the alert translation * Reverting the class names * reverting i am an annoucement due to arguements * finished translations * lint code space after changes * Fixed CI errors * added arguement translation * Update decidim-design/app/helpers/decidim/design/announcement_helper.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-design/app/helpers/decidim/design/announcement_helper.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * review additions and keys changed * rubocop corrections * missing translations added * i am just plain text added * normalization of i18n translations --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Decidim Design translations for the Announcement section.
📌 Related Issues
Testing
📷 Screenshots