Skip to content

Fix newsletter flow in admin panel#12550

Merged
alecslupu merged 8 commits intodevelopfrom
fix/newsletter-preview-size
Mar 11, 2024
Merged

Fix newsletter flow in admin panel#12550
alecslupu merged 8 commits intodevelopfrom
fix/newsletter-preview-size

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

While reviewing #12534, I saw too many details to fix in the newsletter flow, so I decided to take over that PR. The list is the following:

  1. Fix the size in all the newsletter previews
  2. Make consistent usage of the sticky CTA button for the next step
  3. Move the secondary buttons to the right of the header title

📌 Related Issues

Testing

  1. Sign in as admin
  2. Go to http://localhost:3000/admin/newsletters
  3. Sent a newsletter

📷 Screenshots

Before

Screenshot of the newsletter template selection page

Screenshot of the newsletter template preview page

Screenshot of the new newsletter form

Screenshot of the preview page

Screenshot of the select recipient for deliver page

After

Screenshot of the newsletter template selection page (after)

Screenshot of the newsletter template preview page

Screenshot of the new newsletter form

Screenshot of the preview page

Screenshot of the select recipient for deliver page

♥️ Thank you!

@andreslucena andreslucena added module: admin femdev type: fix PRs that implement a fix for a bug and removed femdev labels Mar 1, 2024
github-actions[bot]
github-actions bot previously approved these changes Mar 1, 2024
@andreslucena andreslucena marked this pull request as ready for review March 1, 2024 11:33
@greenwoodt
Copy link
Copy Markdown
Member

👍🏽

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alecslupu alecslupu merged commit a4602be into develop Mar 11, 2024
@alecslupu alecslupu deleted the fix/newsletter-preview-size branch March 11, 2024 09:24
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: admin type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Newsletter preview layout constriction doesn't show the whole content

3 participants