Skip to content

Increase newsletter preview dimensions#12534

Closed
greenwoodt wants to merge 2 commits intodecidim:developfrom
greenwoodt:fix/newsletter-preview-size
Closed

Increase newsletter preview dimensions#12534
greenwoodt wants to merge 2 commits intodecidim:developfrom
greenwoodt:fix/newsletter-preview-size

Conversation

@greenwoodt
Copy link
Copy Markdown
Member

🎩 What? Why?

A previewed Newsletter created within the Decidim system did not provide users with the desirable size to see their work before sending to registered users.

📌 Related Issues

Testing

  1. Login and head over to edit.
  2. Click on Newsletters
  3. Create one and you'll be taken over to Preview it before sending it.
  4. See the sizing more appropriate for the user to view and scroll before sending.

📷 Screenshots

Screenshot 2024-02-27 at 12 48 19

♥️ Thank you!

github-actions[bot]

This comment was marked as resolved.

github-actions[bot]

This comment was marked as resolved.

@andreslucena andreslucena changed the title Increase Newsletter preview dimensions Increase newsletter preview dimensions Feb 27, 2024
@andreslucena andreslucena added type: fix PRs that implement a fix for a bug and removed type: bug labels Feb 27, 2024
github-actions[bot]
github-actions bot previously approved these changes Feb 27, 2024
@andreslucena
Copy link
Copy Markdown
Member

@greenwoodt I'm trying to check out your change and it doesn't seem to work in the page that you're adding the screenshot:

Screenshot of the same page

Also we should use vh (viewport height) instead of h (hardcoded height that doesn't take into account different viewports). If we add something equivalent to height: 40rem; we will have problem with other views (like mobile and tablets in portrait/horizontal mode).

@andreslucena andreslucena self-assigned this Feb 28, 2024
@greenwoodt
Copy link
Copy Markdown
Member Author

@andreslucena see what you think of the latest commit changes.

@andreslucena
Copy link
Copy Markdown
Member

@andreslucena see what you think of the latest commit changes.

Now it's too big, and we can't see the buttons to actually send the newsletter. We should add the sticky buttons. In the other hand, I see other newsletter previews that we need to fix.

As this is growing in scope, and I want to fix the whole process with @carolromero, I'll take care of this. Thanks for the PR @greenwoodt. I'll let you know when it's ready for you to take a look.

@greenwoodt
Copy link
Copy Markdown
Member Author

@andreslucena see what you think of the latest commit changes.

Now it's too big, and we can't see the buttons to actually send the newsletter. We should add the sticky buttons. In the other hand, I see other newsletter previews that we need to fix.

As this is growing in scope, and I want to fix the whole process with @carolromero, I'll take care of this. Thanks for the PR @greenwoodt. I'll let you know when it's ready for you to take a look.

Ok just let me know what you two would prefer to propose as a change. I was having difficultly adjusting the iframe using those tailwind classes. h-lvh wouldn't work without h-full.

@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Mar 1, 2024

@greenwoodt I went ahead an made the PR with all the changes, as it was just faster to just do it instead of explain the changes in all the pages. You can find the result at #12550

@andreslucena
Copy link
Copy Markdown
Member

Closing this in favor of #12550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: admin type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Newsletter preview layout constriction doesn't show the whole content

2 participants