Declare permissions for lint_pr_labels#12413
Merged
alecslupu merged 1 commit intodecidim:developfrom Mar 14, 2024
Merged
Conversation
alecslupu
reviewed
Feb 12, 2024
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
I have checked the proposed fix, and i am not 100 % that is fixed.
https://github.com/tremend-cofe/decidim/actions/runs/7870619005/job/21473093143?pr=304
Valid labels are: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']
Invalid labels are: ['type: bug']
PR reviews are: enabled
Pull request number: 304
Error! This pull request does not contain any of the valid labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']
This pull request does not contain invalid labels
Traceback (most recent call last):
File "/verify_pr_lables.py", line 244, in <module>
event='REQUEST_CHANGES')
File "/usr/local/lib/python3.6/site-packages/github/PullRequest.py", line 485, in create_review
"POST", self.url + "/reviews", input=post_parameters
File "/usr/local/lib/python3.6/site-packages/github/Requester.py", line 319, in requestJsonAndCheck
verb, url, parameters, headers, input, self.__customConnection(url)
File "/usr/local/lib/python3.6/site-packages/github/Requester.py", line 342, in __check
raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/pulls/reviews#create-a-review-for-a-pull-request"}
This are my repo permissions.
Contributor
Author
|
You need to create a PR into https://github.com/tremend-cofe/decidim/tree/text/permissions -- the changes you made to the workflow don't apply to the workflow when it's in the PR because of the behavior of (Yes, it's confusing.) |
Contributor
Author
|
You can see that it worked there: i-need-another-coffee#305 (review) |
andreslucena
approved these changes
Feb 14, 2024
Member
|
Waiting for the last review from @alecslupu so he can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Without this, this workflow fails for PRs in forks
📌 Related Issues
Testing
Create a PR in a fork to a branch with this workflow fixed:
check-spelling-sandbox#2 (review)
📷 Screenshots