Remove code duplication in commands (part 9)#12194
Merged
andreslucena merged 18 commits intodevelopfrom Mar 15, 2024
Merged
Conversation
…r-call-standardization-5
…r-call-standardization-5
andreslucena
requested changes
Mar 14, 2024
Member
andreslucena
left a comment
There was a problem hiding this comment.
I've just checked it out locally, and I only could find minimal details to improve. Congratulations, the code is much cleaner than it was in the classes that inherit from CreateResource/UpdateResource.
I have a few comments to update, and also I think we should add this new feature to the docs. Can you check my feedback out please? Thanks
decidim-assemblies/app/commands/decidim/assemblies/admin/create_assembly.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…r-call-standardization-5
andreslucena
approved these changes
Mar 15, 2024
andreslucena
added a commit
that referenced
this pull request
May 9, 2024
* Remove code duplication in commands * Update docs, clean commented code * Fix typo * Main revert * Patch categories * Patch assemblies * Fix pipeline * Add file_attributes to commands * Remove boilerplate in assemblies * Cleanup Conference boilerplate * Remove more boiler plate in initiatives and participatory process * Fixing failing specs * Running linters * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Adjust docs --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR attempts to standardize the way the file attachments are handled within the commands. This is actually the implementation that I was speaking with @andreslucena in this thread: #12183 (comment)
📌 Related Issues
Link your PR to an issue
Testing