Merge DummyResource and Dev namespaces#12157
Conversation
a86e718 to
5bb1017
Compare
c40577d to
0799d80
Compare
386a323 to
854d593
Compare
andreslucena
left a comment
There was a problem hiding this comment.
I tried it with the metadecidim app locally by changing the config.load_defaults in config/application.rb and everything runs well as is 👏🏽 👏🏽
I've also checked that we've migrated all to the namespace. Things that I've checked:
- "module DummyResources"
- "Decidim::DummyResources"
- the directory name
dummy_resources. The only I could find makes sense (decidim-dev/app/views/decidim/dev/dummy_resources, but that's because we have adummy_resources_controller.rb)
I found a few details and we're good to go
To understand better whats exactly happening here, is this a change between versions on the rails autoloader (with the zeitweirk introduction), right? |
|
🎩 What? Why?
While working to release metaDecidim, we have noticed there are some issues with the factoryBot DummyResource, which was fixed by #12123. While upgrading another application to Decidim 0.28, i have started to see there are a lot of errors like the one in the below image (the same error fixed by #12123). Upon investigation, i have noticed the 2 applications had the rails config "config.load_defaults" different. MetaDecidim used
config.load_defaults 5.1, the faulty application usedconfig.load_defaults 6.1.In order to validate my assumption, i have changed the same config in MetaDecidim, and started to see the same error. I have changed the MetaDecidim gem source to my decidim local folder, and i have started working on the fix. When the implementation was finished, the MetaDecidim test suite was successful.
📌 Related Issues
Link your PR to an issue
Testing
config.load_defaults 6.1inconfig/application.rb, repeat step 2