Fix Decidim::DummyResources autoload path#12123
Merged
andreslucena merged 1 commit intodevelopfrom Dec 5, 2023
Merged
Conversation
0f71266 to
395ded7
Compare
395ded7 to
6a1c895
Compare
6a1c895 to
f74b4c6
Compare
f74b4c6 to
c7416ae
Compare
7e114f0 to
d77afb5
Compare
d77afb5 to
d110aa6
Compare
andreslucena
approved these changes
Dec 5, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
It's not pretty, but to be honest I can't come up with a better way. I understand that this is happening because we have some missing directive on decidim-dev or something like that 🤷🏽.
About the solution, I tried it out in decidim/metadecidim#120 and it works great, so I'm merging it.
Thanks for the fix!
Member
|
Also, I had this meme ready for the first version of the "Testing" section of the PR body:
|
Member
|
Only failing spec is from codecov, so I'm merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While working on decidim/metadecidim#120, @andreslucena observed that
Decidim::DummyResources::DummyResourceis not being recognized.📌 Related Issues
Link your PR to an issue
Testing
The easiest way to test this PR is to apply the changes directly to the installed gem
Then run the test suite.
📷 Screenshots
Please add screenshots of the changes you are proposing