(deprecated) Redesign: clean-up of deprecated classes#12060
Closed
andreslucena wants to merge 1 commit intodevelopfrom
Closed
(deprecated) Redesign: clean-up of deprecated classes#12060andreslucena wants to merge 1 commit intodevelopfrom
andreslucena wants to merge 1 commit intodevelopfrom
Conversation
Member
Author
|
Closing this one as superseded by #12074 See my comment there #12074 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As explained in #11752, we found lots of classes that aren't used anymore by the new CSS that are still in the HTML. This PR continues the process that we've started to clean-up the codebase.
📌 Related Issues
Link your PR to an issue
Testing
As potentially some of these classes could still be used (as they may be generated by SCSS or used as selectors by Capybara), all the specs should be green and everything should work as before.