While reviewing #11685, I noticed lots of CSS classes that shouldn't be in the code any more as they don't have any style defined.
As they were too many to list in that PR and to be able to close that PR in time, we let it pass without fixing all the classes.
So, what need to be done is:
- Search in that PR for the removal of the CSS files
- Pick one class from those files
- Check that it isn't associated any more (for instance by searching with
rg or similar tools)
- If it's in use, check another class
- If the class isn't used, then add it to this rule in
.erb-lint.yml:
DeprecatedClasses:
enabled: true
rule_set:
- deprecated: ['xlarge-[\d]', 'proposal-status']
suggestion: "Remove the class from Foundation CSS"
- Remove that class from the HTML
- Repeat for every class in each removed file
We also should check the classes defined by Foundation. Mind that some classes could be also used by Tailwind (I think I saw something like text-sm or similar)
While reviewing #11685, I noticed lots of CSS classes that shouldn't be in the code any more as they don't have any style defined.
As they were too many to list in that PR and to be able to close that PR in time, we let it pass without fixing all the classes.
So, what need to be done is:
rgor similar tools).erb-lint.yml:We also should check the classes defined by Foundation. Mind that some classes could be also used by Tailwind (I think I saw something like
text-smor similar)