Allow apps to configure the document types in the elections module#11986
Merged
Allow apps to configure the document types in the elections module#11986
Conversation
357daf0 to
8a0c04a
Compare
8a0c04a to
5821af5
Compare
Member
Author
|
The idea is to have something that will be pretty much the same for #9297. The main difference is that as the elections module is still under development (i.e. not officially "published" in a Releases Notes) then we don't need to add the instructions in the CHANGELOG. In the case of decidim-verifications we will need to add the upgrade notes as it's a module actively used by the community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The elections module has a feature in the Census voting that talks about DNI and NIE, some document types specific from Spain.
This PR changes it to "Identification number" and also allows applications to configure whatever document types they need.
The idea is to implement this first for
decidim-electionsand then make a pretty similar change for #9297📌 Related Issues
Testing
Everthing should be green
Following the documentation should allow you to change these values