Skip to content

Use left outer join instead of include in with_any_category scope#11473

Merged
alecslupu merged 2 commits intodevelopfrom
fix/11467
Sep 14, 2023
Merged

Use left outer join instead of include in with_any_category scope#11473
alecslupu merged 2 commits intodevelopfrom
fix/11467

Conversation

@fblupi
Copy link
Copy Markdown
Member

@fblupi fblupi commented Aug 10, 2023

🎩 What? Why?

Use left_outer_joins instead of includes in with_any_category scope to fix the query when adding an order.

📌 Related Issues

Testing

  1. Go to a participatory space with a proposals component.
  2. Go to the proposals component.
  3. Filter by category.
  4. Order by "most commented" or "most followed" and see it works.

♥️ Thank you!

@fblupi fblupi added module: core type: fix PRs that implement a fix for a bug labels Aug 10, 2023
@fblupi fblupi requested a review from a team August 10, 2023 12:40
alecslupu
alecslupu approved these changes Sep 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecslupu alecslupu added this to the 0.28.0 milestone Sep 14, 2023
@alecslupu alecslupu merged commit 7012e38 into develop Sep 14, 2023
@alecslupu alecslupu deleted the fix/11467 branch September 14, 2023 06:47
andreslucena pushed a commit that referenced this pull request Sep 14, 2023
@fblupi @andreslucena
Use left outer join instead of include in with_any_category scope (#1…
2219b3b 
…1473)
fblupi added a commit that referenced this pull request Sep 19, 2023
@fblupi
Use left outer join instead of include in with_any_category scope (#1…
7836366 
…1473)
fblupi added a commit that referenced this pull request Sep 19, 2023
@fblupi
Use left outer join instead of include in with_any_category scope (#1…
43b5229 
…1473)
@fblupi fblupi mentioned this pull request Sep 19, 2023
Merged
alecslupu pushed a commit that referenced this pull request Sep 21, 2023
@fblupi
Use left outer join instead of include in with_any_category scope (#1…
f4732f0 
…1473) (#11614)
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Nov 2, 2023

Not doing the backport to v0.26 as this query wasn't using include on that version: https://github.com/decidim/decidim/blob/release/0.26-stable/decidim-core/lib/decidim/has_category.rb

@fblupi fblupi mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alecslupu alecslupu alecslupu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

No open projects
Maintainers' backlog
Archived in project

Milestone

0.28.0

Development

Successfully merging this pull request may close these issues.

Error ordering proposals after filter them by category

3 participants

@fblupi @andreslucena @alecslupu