Skip to content

Fix scope and category filtering links with ransack#11182

Merged
alecslupu merged 1 commit intodevelopfrom
fix/category-scope-tag-filtering-links
Jul 20, 2023
Merged

Fix scope and category filtering links with ransack#11182
alecslupu merged 1 commit intodevelopfrom
fix/category-scope-tag-filtering-links

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Jul 13, 2023

🎩 What? Why?

After the ransack filtering was introduced, the tag filtering links (category / scope) are not correctly formed.

There are also some other mistakes in the static filtering links that this PR is fixing.

📌 Related Issues

Testing

  • Go to the proposals
  • Open a proposal (considering you have enabled redesign)
  • Click the category or scope filtering link
  • See that the result page is filtering the results correctly

@ahukkanen ahukkanen mentioned this pull request Jul 13, 2023
Closed
@ahukkanen ahukkanen requested a review from a team July 19, 2023 09:09
@andreslucena andreslucena added release: v0.27 Issues or PRs that need to be tackled for v0.27 release: v0.26 Issues or PRs that need to be tackled for v0.26 labels Jul 19, 2023
@ahukkanen ahukkanen removed the release: v0.26 Issues or PRs that need to be tackled for v0.26 label Jul 20, 2023
@ahukkanen
Copy link
Copy Markdown
Contributor Author

ahukkanen commented Jul 20, 2023

@andreslucena I removed the 0.26 label from this because the change was introduced in 0.27.0:
https://github.com/decidim/decidim/releases/tag/v0.27.0

So I believe this only has to be backported to 0.27.

@alecslupu alecslupu mentioned this pull request Jul 20, 2023
Closed
alecslupu
alecslupu approved these changes Jul 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find a way to cancel a sortition in 0.28-dev.

@alecslupu alecslupu merged commit 263aede into develop Jul 20, 2023
@alecslupu alecslupu deleted the fix/category-scope-tag-filtering-links branch July 20, 2023 08:42
@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jul 20, 2023

@ahukkanen please create the backport to 0.27.

@alecslupu alecslupu mentioned this pull request Jul 20, 2023
Closed
@ahukkanen ahukkanen mentioned this pull request Jul 20, 2023
Merged
@ahukkanen
Copy link
Copy Markdown
Contributor Author

ahukkanen commented Jul 20, 2023

Backport building at #11248.

@ahukkanen ahukkanen mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alecslupu alecslupu alecslupu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: budgets module: core module: initiatives module: proposals module: sortitions release: v0.27 Issues or PRs that need to be tackled for v0.27 type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposals: the link to filter by category directly from a proposal card is not working

3 participants

@ahukkanen @alecslupu @andreslucena